[ntuple] better error messages in field reconciliation #20023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the type trace report to help identify the violating subfield in a field hiararchy.
Test Results 22 files 22 suites 3d 20h 49m 10s ⏱️ Results for commit daddb67. |
pcanal
reviewed
Oct 2, 2025
| return (actualTypeName == ROOT::Internal::GetRenormalizedTypeName(ROOT::Internal::GetDemangledTypeName(ti))); | ||
| } | ||
|
|
||
| std::string ROOT::Internal::GetTypeTraceReport(const RFieldBase &field, const RNTupleDescriptor &desc) |
There was a problem hiding this comment.
Could we/Should we add a test that this routine print what we want it to print?
pcanal
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When matching the in-memory field to the on-disk field fails, print a trace of the type hierarchy in-memory and on-disk that helps users to pinpoint the violating sub field.
Follow-up of #19937 (review)