-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cppyy] Move libcppyy.so to <LIBDIR>/cppyy/libcppyy.so #20016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you very much! Good for me once the install tree works 👍
Looking at the current test failure: 2025-09-30T14:28:11.7394805Z Start 1: run-hsimple
2025-09-30T14:28:11.7403649Z Start 3: python-import-root
2025-09-30T14:28:11.7410796Z Start 4: python-create-histo
2025-09-30T14:28:11.7635281Z 1/4 Test #3: python-import-root ...............***Failed 0.02 sec
2025-09-30T14:28:11.7635773Z 2/4 Test #4: python-create-histo ..............***Failed Required regular expression not found. Regex=[myHistoName
2025-09-30T14:28:11.7636194Z ] 0.02 sec
2025-09-30T14:28:12.7766475Z 3/4 Test #1: run-hsimple ...................... Passed 1.04 sec
2025-09-30T14:28:12.7766962Z Start 2: read-hsimple
2025-09-30T14:28:13.0585817Z 4/4 Test #2: read-hsimple ..................... Passed 0.28 sec Are we not running with |
Test Results 21 files 21 suites 3d 20h 6m 15s ⏱️ For more details on these failures, see this check. Results for commit 8f415b7. ♻️ This comment has been updated with latest results. |
Thanks. I'll take care of the patch file later when I do the next cppyy sync |
We indirect do. The individual logs can be found in the "Test Results": eg https://github.com/root-project/root/pull/20016/checks?check_run_id=51624533514 |
I don't know. But we do Thanks, I was not aware of these individual logs! I forgot about them because I noticed that for me, Ctrl+F-ing through the full log was actually faster than clicking around in the web interface, so I started ignoring everything but the full log. |
@hageboeck, if you want to make it also work on Windows, you can use this trick for example: |
123ee7f
to
8792cdb
Compare
This will facilitate moving it to a new location in the next commit.
bf15efb
to
370cd09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Maybe we need the help of @bellenot for Windows after all 🙁 |
When compiling ROOT in Gentoo, the following warning is issued: * Verifying compiled files for python3.13 * * QA Notice: The following unexpected files/directories were found * top-level in the site-packages directory: * * /usr/lib/python3.13/site-packages/libcppyy.so.6.37.01 * * This is most likely a bug in the build system. More information * can be found in the Python Guide: * https://projects.gentoo.org/python/guide/qawarn.html#stray-top-level-files-in-site-packages Similarly to root-project#14917, this can be solved by moving it to <LIBDIR>/cppyy. Therefore: - Move the libray. - Update its RUNPATH for it to find ROOT libraries. - Help Windows find it at its new location. Fix root-project#20015.
370cd09
to
8f415b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice to see that the install testing is preventing us from merging breaking changes! 😄
Another note: can we please also run the wheel building on this PR? It's enough to add the label from the GitHub UI
When compiling ROOT in Gentoo, the following warning is issued:
Similarly to #14917, this can be solved by moving it to /cppyy.
Fix #20015.