[thisroot] resolve symbolic links

[ferdymercury]

Fixes https://its.cern.ch/jira/browse/ROOT-10415

[hageboeck]

Hello, great initiative! I believe I found a hack to do this in a two-liner. I tested locally with the original thisroot.sh and with a link, and both resulted in what I expected.

[github-actions]

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7d3329b.

♻️ This comment has been updated with latest results.

[ferdymercury]

In fish, it's:

set thisroot (path dirname $SOURCE)
set -xg ROOTSYS (set oldpwd $PWD; cd $thisroot/.. > /dev/null;pwd;cd $oldpwd; set -e oldpwd)

In csh, it's:

set thisroot="`dirname ${thisfile}`"
setenv ROOTSYS "`(cd ${thisroot}/..;pwd)`"

But I need help here on how to change it

[hageboeck]

LGTM
It's a very good idea to check for root-config, because that will detect most errors!

[hageboeck]

@ferdymercury we must have made a mistake during merging. I believe that this PR ferdymercury#11 fixes it.

[ferdymercury]

@ferdymercury we must have made a mistake during merging. I believe that this PR ferdymercury#11 fixes it.

Thanks a lot! Seems fixed now.

I'll leave it as "Draft" while we think on how to deal with #19974 (comment)