Skip to content

[CI] Add PR label to skip style checks #19397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

devajithvs
Copy link
Contributor

@devajithvs devajithvs commented Jul 17, 2025

This Pull request:

Introduce support for a skip style checks label to bypass code analysis
workflows like clang-format and ruff.

This is useful in cases such as:

  • Upgrading LLVM, where clang-format and ruff usually fail.
  • Modifying/importing external projects with incompatible formatting.

Not sure of the label name skip style checks but couldn't think of anything better.

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

@devajithvs devajithvs self-assigned this Jul 17, 2025
@devajithvs devajithvs requested a review from dpiparo as a code owner July 17, 2025 13:53
@devajithvs devajithvs added the skip ci Skip the full builds on the actions runners label Jul 17, 2025
@siliataider
Copy link
Contributor

skip style? skip format? no format? ignore format?...

@pcanal
Copy link
Member

pcanal commented Jul 17, 2025

Not sure of the label name skip style checks but couldn't think of anything better.

To match skip ci, I agree it should start with skip. The tests themselves are called (appears in the web page as) "code analysis". Ruff is testing more than just 'style' or formatting (if I remember correctly).

So for better or worse we should consider skip code analysis.

I created and added to this PR the (draft) label with that name.

@pcanal pcanal added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Jul 17, 2025
Introduce support for a `skip code analysis` label to bypass code analysis
workflows like clang-format and ruff.

This is useful in cases such as:
- Upgrading LLVM, where clang-format and ruff usually fail.
- Modifying/importing external projects with incompatible formatting.
@devajithvs
Copy link
Contributor Author

Done! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip ci Skip the full builds on the actions runners skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants