Skip to content

[CI] Disable PyMVA so we can support the newest TensorFlow versions #19124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/root-ci-config/buildconfig/global.txt
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@ testing=ON
tmva-cpu=ON
tmva-gpu=OFF
tmva-cudnn=OFF
tmva-pymva=ON
tmva-pymva=OFF
tmva-rmva=OFF
tmva-sofie=OFF
tmva=ON
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ tmva=ON
tmva-cpu=ON
tmva-gpu=ON
tmva-cudnn=ON
tmva-pymva=ON
tmva-pymva=OFF
fortran=OFF
gdml=OFF
spectrum=OFF
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ onnx

# TMVA: PyMVA interfaces
scikit-learn
tensorflow<2.16 ; python_version < "3.12"
tensorflow ; python_version < "3.13" # TensorFlow doesn't support Python 3.13 yet
torch
xgboost


Unchanged files with check annotations Beta

zmemzero((uint8_t *)s->head, (unsigned)(s->hash_size)*sizeof(*s->head));
/* ========================================================================= */
int ZEXPORT deflateInit_(strm, level, version, stream_size)

Check warning on line 1243 in builtins/zlib/deflate_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 1243 in builtins/zlib/deflate_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
z_streamp strm;
int level;
const char *version;
#define DO8 DO1; DO1; DO1; DO1; DO1; DO1; DO1; DO1
/* ========================================================================= */
local unsigned long crc32_generic(crc, buf, len)

Check warning on line 243 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 243 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
unsigned long crc;
const unsigned char FAR *buf;
uInt len;
return crc ^ 0xffffffffUL;
}
uLong crc32(crc, buf, len)

Check warning on line 277 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 277 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
uLong crc;
const Bytef *buf;
uInt len;
#define DOLIT32 DOLIT4; DOLIT4; DOLIT4; DOLIT4; DOLIT4; DOLIT4; DOLIT4; DOLIT4
/* ========================================================================= */
local unsigned long crc32_little(crc, buf, len)

Check warning on line 294 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 294 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
unsigned long crc;
const unsigned char FAR *buf;
unsigned len;
#define DOBIG32 DOBIG4; DOBIG4; DOBIG4; DOBIG4; DOBIG4; DOBIG4; DOBIG4; DOBIG4
/* ========================================================================= */
local unsigned long crc32_big(crc, buf, len)

Check warning on line 334 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 334 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
unsigned long crc;
const unsigned char FAR *buf;
unsigned len;
#define GF2_DIM 32 /* dimension of GF(2) vectors (length of CRC) */
/* ========================================================================= */
local unsigned long gf2_matrix_times(mat, vec)

Check warning on line 374 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 374 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
unsigned long *mat;
unsigned long vec;
{
}
/* ========================================================================= */
local void gf2_matrix_square(square, mat)

Check warning on line 391 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 391 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
unsigned long *square;
unsigned long *mat;
{
}
/* ========================================================================= */
local uLong crc32_combine_(crc1, crc2, len2)

Check warning on line 402 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 402 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
uLong crc1;
uLong crc2;
z_off64_t len2;
}
/* ========================================================================= */
uLong ZEXPORT crc32_combine(crc1, crc2, len2)

Check warning on line 458 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 458 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
uLong crc1;
uLong crc2;
z_off_t len2;
return crc32_combine_(crc1, crc2, len2);
}
uLong ZEXPORT crc32_combine64(crc1, crc2, len2)

Check warning on line 466 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]

Check warning on line 466 in builtins/zlib/crc32_cf.c

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23

old-style function definition [-Wold-style-definition]
uLong crc1;
uLong crc2;
z_off64_t len2;
for (;;) {
/* create table entry */
here.bits = (unsigned char)(len - drop);
if (work[sym] + 1 < match) {

Check warning on line 211 in builtins/zlib/inftrees.c

GitHub Actions / fedora41

comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]

Check warning on line 211 in builtins/zlib/inftrees.c

GitHub Actions / alma9 march_native CMAKE_BUILD_TYPE=RelWithDebInfo, CMAKE_CXX_FLAGS=-march=native, CMAKE_C_FLAGS=-march=native, fortran=OFF, builtin_zlib=ON, builtin_zstd=ON

comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]

Check warning on line 211 in builtins/zlib/inftrees.c

GitHub Actions / alma10

comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]

Check warning on line 211 in builtins/zlib/inftrees.c

GitHub Actions / alma9 arm64 CMAKE_BUILD_TYPE=RelWithDebInfo, builtin_zlib=ON, builtin_zstd=ON

comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
here.op = (unsigned char)0;
here.val = work[sym];
}