[TMVA] Re-enable many tutorials for which we lost test coverage (PyMVA, SOFIE, RBatchGenerator) #19123
+27
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR root-project#17098, the check in `tutorials/CMakeLists.txt` if ROOT is built with PyMVA was accidentally corrupted by also renaming the build option from `tmva-pymva` to `machine_learning-pymva`. This resulted in the dependencies of the PyMVA, SOFIE, and RBatchGenerator tutorials never being looked for, and then the tutorials were always vetoed because the dependencies were not found. Meaning, we didn't run these tutorials since November last year. This commit fixes that by always checking for the Python modules.
This makes the configuration less error prone.
guitargeek
force-pushed
the
pymva_tutorials
branch
from
8a89300 to
0aed3a1
Compare
guitargeek
changed the title
This was referenced Jun 22, 2025
guitargeek
changed the title
Test Results 20 files 20 suites 4d 2h 9m 25s ⏱️ For more details on these failures, see this check. Results for commit 0aed3a1. |
dpiparo
approved these changes
Jun 23, 2025
This was referenced Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #17098, the check in
tutorials/CMakeLists.txtif ROOT is built with PyMVA was accidentally corrupted by also renaming the build option fromtmva-pymvatomachine_learning-pymva.This resulted in the dependencies of the PyMVA, SOFIE, and RBatchGenerator tutorials never being looked for, and then the tutorials were always vetoed because the dependencies were not found. Meaning, we didn't run these tutorials since November last year.
This commit fixes that by always checking for the Python modules.