[6.36][io] TFileMerger: fail by default on invalid keys #18919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a `Error Behavior` flag in TFileMerger that determines what should happen upon encountering errors. The only place where this flag is currently honored is when reading an object's key inside MergeOne(): up until now if an error happened when retrieving an object from a file, the file would just be skipped. With the introduction of this flag, you can decide whether the file is skipped or if the merging process should abort. For consistency with hadd, the default behavior has been set to Fail. Using `hadd -k` will set the behavior to Skip. (cherry picked from commit 5f5fa73)
Test Results 19 files 19 suites 3d 13h 24m 50s ⏱️ For more details on these failures, see this check. Results for commit 3cc3873. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
Jun 2, 2025
silverweed
merged commit 38996ff
into
root-project:v6-36-00-patches
42 of 45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BP of #18800