[ntuple] Initial integration with TBrowser #18889
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to ROOT::MergeFunc_t, the function pointer for the Browse() function will allow custom browsing for objects that don't derive from TObject.
silverweed
reviewed
May 28, 2025
| @@ -233,6 +233,7 @@ friend class TStreamerInfo; | |||
| IsAGlobalFunc_t fGlobalIsA; //pointer to a global IsA function. | |||
| mutable std::atomic<TMethodCall*> fIsAMethod; //!saved info to call a IsA member function | |||
|
|
|||
| ROOT::BrowseFunc_t fBrowse; //pointer to a functionen implementing the TBrowser Browse() call. | |||
| @@ -1145,7 +1145,7 @@ TClass::TClass() : | |||
| fInstanceCount(0), fOnHeap(0), | |||
| fCheckSum(0), fCollectionProxy(nullptr), fClassVersion(0), fClassInfo(nullptr), | |||
| fTypeInfo(nullptr), fShowMembers(nullptr), | |||
| fStreamer(nullptr), fIsA(nullptr), fGlobalIsA(nullptr), fIsAMethod(nullptr), | |||
| fStreamer(nullptr), fIsA(nullptr), fGlobalIsA(nullptr), fIsAMethod(nullptr), fBrowse(nullptr), | |||
There was a problem hiding this comment.
At some point it would be nice to inline all these initializations...
silverweed
reviewed
May 28, 2025
| @@ -94,7 +94,7 @@ namespace Internal { | |||
| fImplFileName(nullptr), fImplFileLine(0), | |||
| fIsA(isa), | |||
| fVersion(1), | |||
| fMerge(nullptr),fResetAfterMerge(nullptr),fNew(nullptr),fNewArray(nullptr),fDelete(nullptr),fDeleteArray(nullptr),fDestructor(nullptr), fDirAutoAdd(nullptr), fStreamer(nullptr), | |||
| fBrowse(nullptr),fMerge(nullptr),fResetAfterMerge(nullptr),fNew(nullptr),fNewArray(nullptr),fDelete(nullptr),fDeleteArray(nullptr),fDestructor(nullptr), fDirAutoAdd(nullptr), fStreamer(nullptr), | |||
There was a problem hiding this comment.
At some point it would be nice to inline all these initializations...
and these as well
Test Results 19 files 19 suites 3d 19h 34m 28s ⏱️ For more details on these failures, see this check. Results for commit 74927a3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds minimal browsing capability for RNTuple with TBrowser (browsing already works with RBrowser). Introduces the more general capability for foreign objects (not inherited from TObject) to implement custom browsing. This is done similar to a custom merge function, by a special method signature that is picked up by the dictionary generation and registered in TClass. This capability is then used by the RNTuple anchor object.
As a result, TBrowser can show the structure of an RNTuple. Note that RNTuple only uses the abstract TBrowser interface, which is part of the core library.
In a follow-up PR,histogramming data is to be implemented. The idea is that the graphical browser will register an RNTuple visitor for the drawing, so that the GUI will depend on the RNTuple library but not vice versa.
Icons in the tree view panel of the browser need to be fixed, too.