-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[tree] Double32/Float16 avoid overwriting title from base class since it contains leafcounter #18829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ferdymercury
wants to merge
17
commits into
root-project:master
Choose a base branch
from
ferdymercury:patch-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
ferdymercury
commented
May 21, 2025
ferdymercury
commented
May 21, 2025
ferdymercury
commented
May 21, 2025
ferdymercury
commented
May 21, 2025
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
pcanal
reviewed
May 21, 2025
Test Results 19 files 19 suites 3d 14h 41m 1s ⏱️ Results for commit 1d4e8be. ♻️ This comment has been updated with latest results. |
ferdymercury
commented
May 22, 2025
ferdymercury
commented
May 22, 2025
ferdymercury
commented
May 22, 2025
ferdymercury
commented
May 22, 2025
ferdymercury
commented
May 22, 2025
pcanal
reviewed
May 22, 2025
pcanal
reviewed
May 22, 2025
pcanal
reviewed
May 23, 2025
ferdymercury
commented
May 23, 2025
ferdymercury
commented
May 23, 2025
ferdymercury
commented
May 24, 2025
with truncated data types, where name != title in TLeaf / TNamed
as suggested by pcanal
[tree] append only bracket custom part, skip data type [tree] fix streamer
as suggested by pcanal
as suggested by pcanal
Loading status checks…
to easen debug
ferdymercury
commented
May 25, 2025
Loading status checks…
Loading status checks…
Test is passing now. |
Loading status checks…
Loading status checks…
…ength
Loading status checks…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes https://its.cern.ch/jira/browse/ROOT-10149
fyi @Triple-S
Context: 5b2bc09#diff-cb6d6533f05ffb9510627ac9d183f78821be4214f1b640ae050d4bac271c1daaR50 from #3463
Checklist: