Skip to content

[tree] Double32/Float16 avoid overwriting title from base class since it contains leafcounter #18829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented May 21, 2025

This Pull request:

Changes or fixes:

Fixes https://its.cern.ch/jira/browse/ROOT-10149

fyi @Triple-S

Context: 5b2bc09#diff-cb6d6533f05ffb9510627ac9d183f78821be4214f1b640ae050d4bac271c1daaR50 from #3463

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Sorry, something went wrong.

@ferdymercury ferdymercury changed the title [tree] get leaf name, not title, since title is reused to store truncated double limits [tree] do not overwrite title since it is reused to store truncated double limits May 21, 2025
@ferdymercury ferdymercury changed the title [tree] do not overwrite title since it is reused to store truncated double limits [tree] do not overwrite title since it must also contain leafcounter May 21, 2025
Copy link

github-actions bot commented May 21, 2025

Test Results

    19 files      19 suites   3d 14h 41m 1s ⏱️
 2 780 tests  2 780 ✅ 0 💤 0 ❌
51 318 runs  51 318 ✅ 0 💤 0 ❌

Results for commit 1d4e8be.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury added this to the 6.38.00 milestone May 22, 2025
@ferdymercury ferdymercury changed the title [tree] do not overwrite title since it must also contain leafcounter [tree] Double32/Float16 do not overwrite title since it must also contain leafcounter May 23, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ferdymercury ferdymercury requested a review from pcanal May 25, 2025 15:19
@ferdymercury ferdymercury marked this pull request as ready for review May 25, 2025 15:19
@ferdymercury
Copy link
Collaborator Author

Test is passing now.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ength

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants