Skip to content

[Math][GenVector] Replace M_PI* with TMath function calls #18659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Math][GenVector] Replace M_PI* with TMath function calls #18659

wants to merge 1 commit into from

Conversation

mdessole
Copy link
Contributor

@mdessole mdessole commented May 8, 2025

This Pull request:

Replaces M_PI* occurences with TMath function calls, following discussion in #18462

@mdessole mdessole self-assigned this May 8, 2025
@mdessole mdessole requested a review from pcanal May 8, 2025 08:56
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2025

Test Results

    19 files      19 suites   4d 4h 56m 53s ⏱️
 2 739 tests  2 727 ✅ 0 💤 12 ❌
50 566 runs  50 554 ✅ 0 💤 12 ❌

For more details on these failures, see this check.

Results for commit c53f437.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal Awaiting requested review from pcanal

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta will be requested when the pull request is marked ready for review lmoneta is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mdessole mdessole

Labels
in:Math Libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdessole