Skip to content

[tree] return NaN instead of zero when out of bonds in TreeFormula #18610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented May 5, 2025

This Pull request:

Changes or fixes:

Fixes https://its.cern.ch/jira/browse/ROOT-7348
(And/or the dupe https://its.cern.ch/jira/browse/ROOT-7465)

fyi @cburgard @pieterdavid @longjon @fbuehrer

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury ferdymercury marked this pull request as ready for review May 5, 2025 16:56
@ferdymercury ferdymercury requested a review from pcanal as a code owner May 5, 2025 16:56
@ferdymercury ferdymercury requested a review from dpiparo as a code owner May 5, 2025 17:51
Copy link

github-actions bot commented May 5, 2025

Test Results

    19 files      19 suites   3d 21h 13m 26s ⏱️
 2 739 tests  2 739 ✅ 0 💤 0 ❌
50 608 runs  50 608 ✅ 0 💤 0 ❌

Results for commit be4aeb1.

♻️ This comment has been updated with latest results.

Co-authored-by: Philippe Canal <[email protected]>
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ferdymercury ferdymercury marked this pull request as draft May 7, 2025 21:31
and void index 0 which is special def case fNData==1
@ferdymercury ferdymercury marked this pull request as ready for review May 8, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants