-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[tree] return NaN instead of zero when out of bonds in TreeFormula #18610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ferdymercury
wants to merge
10
commits into
root-project:master
Choose a base branch
from
ferdymercury:evalbonds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+78
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 3d 21h 13m 26s ⏱️ Results for commit be4aeb1. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
May 7, 2025
pcanal
reviewed
May 7, 2025
pcanal
reviewed
May 7, 2025
Co-authored-by: Philippe Canal <[email protected]>
pcanal
reviewed
May 7, 2025
pcanal
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
ferdymercury
commented
May 7, 2025
and void index 0 which is special def case fNData==1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes https://its.cern.ch/jira/browse/ROOT-7348
(And/or the dupe https://its.cern.ch/jira/browse/ROOT-7465)
fyi @cburgard @pieterdavid @longjon @fbuehrer
Checklist: