[meta] Correct TClass::LoadClassInfo. #18587
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes root-project#18556. We should keep trying to try to load a ClassInfo until we try the auto-parsing. TClass::LoadClassInfo should set fCanLoadClassInfo to false when the ClassInfois found *and* set it to false also when we tried auto parsing but did not find the ClassInfo. In the later case, the ClassInfo might still be loaded (via a different routine/mechanims) if information about the class is later loaded/parsed.
Test Results 18 files 18 suites 3d 21h 19m 38s ⏱️ For more details on these failures, see this check. Results for commit e682128. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #18556.
We should keep trying to try to load a ClassInfo until we try the
auto-parsing. TClass::LoadClassInfo should set fCanLoadClassInfo tofalse when the ClassInfois found and set it to false also when we tried
auto parsing but did not find the ClassInfo.
In the later case, the ClassInfo might still be loaded (via a different
routine/mechanims) if information about the class is later loaded/parsed.