[ntuple] Read more than one cluster group - #415
Merged
Conversation
Member
|
Can you address warnings and errors reported by |
undefined-panda
force-pushed
the
rntuple-cluster-groups
branch
from
August 13, 2026 08:06
d390dec to
a84102f
Compare
Contributor
Author
There were variables left from debugging. I removed them. |
silverweed
approved these changes
Aug 13, 2026
silverweed
left a comment
silverweed
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just one comment
undefined-panda
force-pushed
the
rntuple-cluster-groups
branch
2 times, most recently
from
August 13, 2026 08:26
f582421 to
4c68667
Compare
Fix reading of RNTuples with multiple calls of RNTupleWriter::CommitCluster(commitClusterGroup=true). Previously only entries from the first cluster group were deserialized because deserializePageList and _readNestedFrames overwrote the data of additional groups instead of appending them.
undefined-panda
force-pushed
the
rntuple-cluster-groups
branch
from
August 13, 2026 08:27
4c68667 to
3534e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes:
readHeaderFooternow iterates over all cluster groupsdeserializePageListappends toclusterSummariesinstead of resetting it on every call_readNestedFramesappends topageLocationsinstead of resetting it on every callFixes:
RNTuple files written with multiple cluster groups (i.e. multiple calls of
RNTupleWriter::CommitCluster(commitClusterGroup=true)) are now read completely. Previously only the entries of the first cluster group were returned, whereas all subsequent groups were silently dropped.