Added menu, changed button #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bravo555
reviewed
Oct 24, 2016
| text.setString(textString); | ||
| text.setCharacterSize(characterSize); | ||
|
|
||
| Button::Button(sf::RenderWindow &win) : window(win){ |
Bravo555
reviewed
Oct 24, 2016
| } | ||
| void Button::draw() { | ||
| window.draw(background); | ||
| window.draw(text); | ||
|
|
||
| } | ||
| void Button::setPosition (float x, float y, float width, float height){ | ||
| void Button::setPosition (float x, float y){ |
Bravo555
requested changes
Oct 24, 2016
| void Button::setFont(sf::Font &font){ | ||
| text.setFont(font); | ||
| } | ||
| void Button::setColors(sf::Color backgroundColor, sf::Color textColor){ |
There was a problem hiding this comment.
We dont know what is background color and what is text color. I think we should make two separate functions: setBackgoundColor() and setTextColor
| void draw(); | ||
| void setPosition(float x, float y, float width, float height); | ||
| void setPosition(sf::Vector2f vector); | ||
| void setPosition(float x, float y); |
| sf::RectangleShape background; | ||
| sf::Event event; | ||
| sf::Color backgroundColor; | ||
| sf::Color textColor; | ||
| int width, height; |
There was a problem hiding this comment.
Do we ever use these variables in actual code? If I checked it correctly, we neither use nor update them. Also, why are these ints, while rectangle size is a float?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.