Reorder the operations do we don't accidentally enter the UCI short-c…

…ircuit
rooklift · Feb 8, 2024 · ced19b3 · ced19b3
1 parent cfe8feb
commit ced19b3
Showing 1 changed file with 14 additions and 14 deletions.
diff --git a/files/src/renderer/40_position.js b/files/src/renderer/40_position.js
@@ -747,20 +747,6 @@ const position_prototype = {
 
 	parse_pgn: function(s) {		// Returns a UCI move and an error message.
 
-		// Replace fruity dash characters with proper ASCII dash "-"
-
-		for (let n of [8208, 8210, 8211, 8212, 8213, 8722]) {
-			s = ReplaceAll(s, String.fromCodePoint(n), "-");
-		}
-
-		// Delete things we don't need...
-
-		s = ReplaceAll(s, "x", "");
-		s = ReplaceAll(s, "+", "");
-		s = ReplaceAll(s, "#", "");
-		s = ReplaceAll(s, "!", "");
-		s = ReplaceAll(s, "?", "");
-
 		// If the string contains any dots it'll be something like "1.e4" or "...e4" or whatnot...
 
 		let lio = s.lastIndexOf(".");
@@ -784,6 +770,20 @@ const position_prototype = {
 			}
 		}
 
+		// Replace fruity dash characters with proper ASCII dash "-"
+
+		for (let n of [8208, 8210, 8211, 8212, 8213, 8722]) {
+			s = ReplaceAll(s, String.fromCodePoint(n), "-");
+		}
+
+		// Delete things we don't need...
+
+		s = ReplaceAll(s, "x", "");
+		s = ReplaceAll(s, "+", "");
+		s = ReplaceAll(s, "#", "");
+		s = ReplaceAll(s, "!", "");
+		s = ReplaceAll(s, "?", "");
+
 		// Fix castling with zeroes...
 
 		s = ReplaceAll(s, "0-0-0", "O-O-O");