Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove unused Execute() #361

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

nirs
Copy link
Contributor

@nirs nirs commented Feb 26, 2025

The root command is executed from main() directly so Execute is unused. Its only effect seems to be confusing new contributor.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation not needed.
  • Unit tests not needed.
  • Integration tests not needed.

The root command is executed from main() directly so Execute is unused.
Its only effect seems to be confusing new contributor.

Signed-off-by: Nir Soffer <[email protected]>
@nirs nirs changed the title commands: Remove unused Execute() core: remove unused Execute() Feb 26, 2025
@subhamkrai subhamkrai merged commit 03bbd91 into rook:master Feb 27, 2025
6 checks passed
@subhamkrai
Copy link
Collaborator

Thanks for the PR @nirs

@nirs nirs deleted the remove-execute branch February 27, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants