Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi: fix rbd listing failure by correctly filtering builtin block pools #357

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

OdedViner
Copy link
Contributor

#356

Previously, the code only filtered out "builtin-mgr", but other builtin pools still caused rbd ls to fail. This fix updates the condition to exclude all pools containing "builtin", preventing errors when listing RBD images.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@subhamkrai subhamkrai merged commit 249ae9a into rook:master Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants