Update debug to maintenance #252
Conversation
docs/mons.md
Outdated
| Info: The mons to discard are: b a | ||
| Info: Are you sure you want to restore the quorum to mon "c"? If so, enter: yes-really-restore | ||
| # Info: mon c state is leader | ||
| # mon=b, endpoint=192.168.64.168:6789 |
There was a problem hiding this comment.
Do all of these lines have the # prefix? I thought some output lines don't have it.
There was a problem hiding this comment.
# prefix is only to separate output from commands. We don't add # in front of the command output.
There was a problem hiding this comment.
I'd suggest if there are commands in the same block with the output, the command would have the $ prefix, while the output is exactly as we see it in the console. I thought this was the pattern for the rook docs, which we could follow here as well.
There was a problem hiding this comment.
I have removed # from the output now and slowly going in the future I feel maintaining the long output will become maintenance burden
There was a problem hiding this comment.
Yeah let's discuss about long term
subhamkrai
force-pushed
the
update-debug-to-maintenance
branch
from
995ed50 to
35d4ded
Compare
subhamkrai
force-pushed
the
update-debug-to-maintenance
branch
from
35d4ded to
bc17078
Compare
debug command can be confusing for users so after discussion with team we are changing it to maintenance command. Signed-off-by: subhamkrai <[email protected]>
subhamkrai
force-pushed
the
update-debug-to-maintenance
branch
from
bc17078 to
94c521d
Compare
docs/mons.md
Outdated
| Info: Mon quorum was successfully restored to mon c | ||
| Info: Only a single mon is currently running | ||
| Info: Press Enter to start the operator and expand to full mon quorum again | ||
| Error: failed to run command. failed to run command. command terminated with exit code 1%!(EXTRA string=failed to get the status of ceph cluster) |
There was a problem hiding this comment.
updating this fixed the issue
docs/mons.md
Outdated
| Info: The mons to discard are: b a | ||
| Info: Are you sure you want to restore the quorum to mon "c"? If so, enter: yes-really-restore | ||
| # Info: mon c state is leader | ||
| # mon=b, endpoint=192.168.64.168:6789 |
There was a problem hiding this comment.
Yeah let's discuss about long term
since updating debug to maintenance, it requires changing in mons restore command as it used debug mode or maintenance mode for restoring mons. Signed-off-by: subhamkrai <[email protected]>
let's add 'maintenance' as commitlint title to make bot happy and also updating ci tests. Signed-off-by: subhamkrai <[email protected]>
subhamkrai
force-pushed
the
update-debug-to-maintenance
branch
from
94c521d to
273b8e5
Compare
Description of your changes:
maintenance: update debug cmd to maintenance cmd
debug command can be confusing for users so after discussion with
team we are changing it to maintenance command.
mons: update restore-quorum logs and docs
since updating debug to maintenance, it requires
changing in the mons restore command as it used debug mode
or maintenance mode for restoring mons.
Which issue is resolved by this Pull Request:
Resolves #
Checklist: