Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update runner go version to 1.21 #248

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

subhamkrai
Copy link
Collaborator

created a composite yaml for setting up go versio
that will be use for CI and releaser yaml. The releaser ci is failing https://github.com/rook/kubectl-rook-ceph/actions/runs/8003450560/job/21858788476 with error

  ⨯ release failed after 0s                  error=hook failed: shell: 'go mod tidy': exit status 1: go: go.mod file indicates go 1.21, but maximum version supported by tidy is 1.20

hopefull after this, releaser ci will be happy.

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • CI tests has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.

@subhamkrai subhamkrai requested a review from travisn February 22, 2024 11:16
@subhamkrai subhamkrai force-pushed the update-go-version branch 3 times, most recently from 680e4d9 to b785d57 Compare February 22, 2024 11:21
created a composite yaml for setting up go version
that will be use for CI and releaser yaml. The releaser
ci is failing https://github.com/rook/kubectl-rook-ceph/actions/runs/8003450560/job/21858788476
with error
```
  ⨯ release failed after 0s                  error=hook failed: shell: 'go mod tidy': exit status 1: go: go.mod file indicates go 1.21, but maximum version supported by tidy is 1.20
```
hopefull after this, releaser ci will be happy.

Signed-off-by: subhamkrai <[email protected]>
@subhamkrai subhamkrai merged commit aba01b0 into rook:master Feb 22, 2024
6 checks passed
@subhamkrai subhamkrai deleted the update-go-version branch February 22, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants