-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address typing hints for xarray 2023.08 compatibility, Update ReadTheDocs #295
Conversation
Pull Request Test Coverage Report for Build 5929676609
💛 - Coveralls |
@@ -2,7 +2,7 @@ name: clisops | |||
channels: | |||
- conda-forge | |||
dependencies: | |||
- python >=3.8 | |||
- python >=3.8,<3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why < 3.12 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReadTheDocs will try to build the documentation with the highest available version. CLISOPS only supports Python >=3.8,<3.12 at the moment.
…ps to environment.yml
Pull Request Checklist:
AUTHORS.md
Fixes an issue with existing type hinting raised by changes in the API of xarray (2023.08).
Also updates the ReadTheDocs configuration to use
Mambaforge
by default.No. Only type hinting is affected (it's more accurate now).
pydata/xarray#7368