[cli] Fix Nativewind home layout, TabBarIcon types, and rerun-hint quoting#612
Merged
Conversation
- Give EditScreenInfo's outer View w-full: ScreenContent centers its children, so the unconstrained View sized to the text's intrinsic single-line width and the description clipped at the screen edge. - Inset the Show Details button with mx-6; the Container only has safe-area padding, which is zero horizontally on iPhones, so the stretched button touched the screen edges. - Type TabBarIcon color as ColorValue: Expo Router's Tabs on SDK 56 passes ColorValue to tabBarIcon, which fails typechecking against color: string. @expo/vector-icons accepts string | OpaqueColorValue. - Only quote the rerun-hint project name when it contains characters that actually need shell quoting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mirror of #611 for the v4 (main) templates, plus one main-only fix:
ScreenContentcenters its children (items-center), soEditScreenInfo's unconstrained outerViewsized itself to the text's intrinsic single-line width and the description clipped at the screen edge. Give itw-fullso the text wraps.Containeronly hasp-safe, which is zero horizontally on iPhones in portrait, and the stretched button spanned edge to edge. Addmx-6to the button on the Nativewind stack home screen.Tabson SDK 56 passesColorValuetotabBarIcon, which failstscagainst the baseTabBarIcon'scolor: string. Type it asColorValue—@expo/vector-iconsacceptsstring | OpaqueColorValue, so both Expo Router and React Navigation callers fit. (Not caught by CI because main's matrix doesn't include--nativewind --expo-router --tabs.)quoteShellArgnow returns safe-charset values unchanged and only quotes names with spaces or other special characters.Related Issue
N/A — spotted during manual testing of generated apps. Same fixes applied to
nextin #611.Motivation and Context
Fresh
--nativewind --expo-routerprojects had visibly broken layout on first launch, and--nativewind --expo-router --tabsprojects fail typechecking on SDK 56.How Has This Been Tested?
bun run build(tsc + ejslint) passes--nativewind --expo-routerproject: new classes present in output,tsc --noEmitexits 0Screenshots (if appropriate):
Before: button spans the full screen width; description text ends mid-sentence at the screen edge.
Generated by Claude Code