BREAKING_CHANGE: refactor repo #138

TuDo1403 · 2024-10-18T18:57:40Z

Description

Contract changes

The table below shows the following info:

Logic: the logic is changed.
ABI: the ABI is changed.
Init data: new storage field is declared and needs initializing.
Dependent: needs to be changed due to changes in other contracts.

Contract name	Logic	ABI	Init data	Dependent
FastFinalityTracking
GovernanceAdmin
Maintenance
Profile
SlashIndicator
Staking
StakingVesting
ValidatorSet

Checklist

I have chosen the base of the PR to the release/** branch.
I have named the PR following the format of [contract_name] what_is_changed, where contract_name is the list of changed contracts, separated by |, or is * if there is changed in more than 3 contracts
I have ticked in the Contract changes table to guide the deployer which contracts to be upgraded.
I have clearly commented on all the main functions following the NatSpec Format
The box that allows repo maintainers to update this PR is checked
I tested locally to make sure this feature/fix works

…pply-forge-structure feat(refactor): implement `apply-forge-structure`

…pdate-new-config feat(refactor): implement `update-new-config`

feat(refactor): implement `test`

Co-authored-by: TuDo1403 <[email protected]>

github-actions · 2024-10-22T05:19:53Z

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

reentrancy-eth (6 results) (High)
shadowing-state (4 results) (High)
uninitialized-state (13 results) (High)

reentrancy-eth

Impact: High
Confidence: Medium

ID-0
Reentrancy in CoinbaseExecution.wrapUpEpoch():
External calls:

dpos-contract/src/ronin/validator/CoinbaseExecution.sol

Lines 102 to 162 in 21d1a93

    
           function wrapUpEpoch() external payable virtual override onlyCoinbase whenEpochEnding oncePerEpoch { 
        
             unchecked { 
        
               uint256 newPeriod = _computePeriod(block.timestamp); 
        
               bool periodEnding = _isPeriodEnding(newPeriod); 
        
               uint256 lastPeriod = currentPeriod(); 
        
               uint256 epoch = epochOf(block.number); 
        
               uint256 nextEpoch = epoch + 1; 
        
               IRandomBeacon randomBeacon = IRandomBeacon(getContract(ContractType.RANDOM_BEACON)); 
        
               // This request is actually only invoked at the first epoch of the period. 
        
               randomBeacon.execRequestRandomSeedForNextPeriod(lastPeriod, newPeriod); 
        
               // Get all candidate ids 
        
               address[] memory allCids = _candidateIds; 
        
               _syncFastFinalityReward({ epoch: epoch, validatorIds: allCids }); 
        
               if (periodEnding) { 
        
                 ISlashIndicator slashIndicatorContract = ISlashIndicator(getContract(ContractType.SLASH_INDICATOR)); 
        
                 // Slash submit random beacon proof unavailability first, then update credit scores. 
        
                 randomBeacon.execRecordAndSlashUnavailability(lastPeriod, newPeriod, address(slashIndicatorContract), allCids); 
        
                 slashIndicatorContract.execUpdateCreditScores(allCids, lastPeriod); 
        
                 (uint256[] memory delegatorBlockMiningRewards, uint256[] memory delegatorFastFinalityRewards) = 
        
                   _distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward(lastPeriod, allCids); 
        
                 _settleAndTransferDelegatingRewards( 
        
                   lastPeriod, allCids, delegatorBlockMiningRewards, delegatorFastFinalityRewards 
        
                 ); 
        
                 _tryRecycleLockedFundsFromEmergencyExits(); 
        
                 _recycleDeprecatedRewards(); 
        
                 address[] memory revokedCandidateIds = _syncCandidateSet(newPeriod); 
        
                 if (revokedCandidateIds.length > 0) { 
        
                   // Re-update `allCids` after unsatisfied candidates get removed. 
        
                   allCids = _candidateIds; 
        
                   slashIndicatorContract.execResetCreditScores(revokedCandidateIds); 
        
                 } 
        
                 // Wrap up the beacon period includes (1) finalizing the beacon proof, and (2) determining the validator list for the next period by new proof. 
        
                 // Should wrap up the beacon after unsatisfied candidates get removed. 
        
                 randomBeacon.execFinalizeBeaconAndPendingCids(lastPeriod, newPeriod, allCids); 
        
                 _periodEndBlock[lastPeriod] = block.number; 
        
                 _currentPeriodStartAtBlock = block.number + 1; 
        
               } 
        
               // Clear the previous validator set and block producer set before sync the new set from beacon. 
        
               _clearPreviousValidatorSetAndBlockProducerSet(); 
        
               // Query the new validator set for upcoming epoch from the random beacon contract. 
        
               // Save new set into the contract storage. 
        
               address[] memory newValidatorIds = _syncValidatorSet(randomBeacon, newPeriod, nextEpoch); 
        
               // Activate applicable validators into the block producer set. 
        
               _updateApplicableValidatorToBlockProducerSet(newPeriod, nextEpoch, newValidatorIds); 
        
               emit WrappedUpEpoch(lastPeriod, epoch, periodEnding); 
        
               _periodOf[nextEpoch] = newPeriod; 
        
               _lastUpdatedPeriod = newPeriod; 
        
             } 
        
           }

ID-1
Reentrancy in CoinbaseExecution._distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward(uint256,address[]):
External calls:
- _distributeMiningReward(vId,treasury)
  - (success,None) = recipient.call{gas: gas,value: amount}()
- _distributeFastFinalityReward(vId,treasury,validatorFFReward)
  - (success,None) = recipient.call{gas: gas,value: amount}()
    State variables written after the call(s):
- delete _delegatorMiningReward[vId]
  CommonStorage._delegatorMiningReward can be used in cross function reentrancies:
- CoinbaseExecution._distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward(uint256,address[])
- CoinbaseExecution.submitBlockReward()
- delete _fastFinalityReward[vId]
  CommonStorage._fastFinalityReward can be used in cross function reentrancies:
- CoinbaseExecution._distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward(uint256,address[])
- CoinbaseExecution._syncFastFinalityReward(uint256,address[])
- _totalDeprecatedReward += _validatorMiningReward[vId] + _delegatorMiningReward[vId] + _fastFinalityReward[vId]
  CommonStorage._totalDeprecatedReward can be used in cross function reentrancies:
- CoinbaseExecution._distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward(uint256,address[])
- CoinbaseExecution._recycleDeprecatedRewards()
- CoinbaseExecution._syncFastFinalityReward(uint256,address[])
- EmergencyExit._tryRecycleLockedFundsFromEmergencyExits()
- CoinbaseExecution.submitBlockReward()
- CommonStorage.totalDeprecatedReward()
- delete _validatorMiningReward[vId]
  CommonStorage._validatorMiningReward can be used in cross function reentrancies:
- CoinbaseExecution._distributeMiningReward(address,address)
- CoinbaseExecution._distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward(uint256,address[])
- CoinbaseExecution.submitBlockReward()

dpos-contract/src/ronin/validator/CoinbaseExecution.sol

Lines 206 to 244 in 21d1a93

    
           function _distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward( 
        
             uint256 lastPeriod, 
        
             address[] memory cids 
        
           ) private returns (uint256[] memory delegatorBlockMiningRewards, uint256[] memory delegatorFastFinalityRewards) { 
        
             address vId; // validator id 
        
             address payable treasury; 
        
             uint256 length = cids.length; 
        
             delegatorBlockMiningRewards = new uint256[](length); 
        
             delegatorFastFinalityRewards = new uint256[](length); 
        
             (uint256 minRate, uint256 maxRate) = IStaking(getContract(ContractType.STAKING)).getCommissionRateRange(); 
        
             for (uint256 i; i < length; ++i) { 
        
               vId = cids[i]; 
        
               treasury = _candidateInfo[vId].__shadowedTreasury; 
        
               if (!_isJailedById(vId) && !_miningRewardDeprecatedById(vId, lastPeriod)) { 
        
                 (uint256 validatorFFReward, uint256 delegatorFFReward) = _calcCommissionReward({ 
        
                   vId: vId, 
        
                   totalReward: _fastFinalityReward[vId], 
        
                   maxCommissionRate: maxRate, 
        
                   minCommissionRate: minRate 
        
                 }); 
        
                 delegatorBlockMiningRewards[i] = _delegatorMiningReward[vId]; 
        
                 delegatorFastFinalityRewards[i] = delegatorFFReward; 
        
                 _distributeMiningReward(vId, treasury); 
        
                 _distributeFastFinalityReward(vId, treasury, validatorFFReward); 
        
               } else { 
        
                 _totalDeprecatedReward += _validatorMiningReward[vId] + _delegatorMiningReward[vId] + _fastFinalityReward[vId]; 
        
               } 
        
               delete _delegatorMiningReward[vId]; 
        
               delete _validatorMiningReward[vId]; 
        
               delete _fastFinalityReward[vId]; 
        
             } 
        
           }

ID-2
Reentrancy in CoinbaseExecution.wrapUpEpoch():
External calls:

dpos-contract/src/ronin/validator/CoinbaseExecution.sol

Lines 102 to 162 in 21d1a93

    
           function wrapUpEpoch() external payable virtual override onlyCoinbase whenEpochEnding oncePerEpoch { 
        
             unchecked { 
        
               uint256 newPeriod = _computePeriod(block.timestamp); 
        
               bool periodEnding = _isPeriodEnding(newPeriod); 
        
               uint256 lastPeriod = currentPeriod(); 
        
               uint256 epoch = epochOf(block.number); 
        
               uint256 nextEpoch = epoch + 1; 
        
               IRandomBeacon randomBeacon = IRandomBeacon(getContract(ContractType.RANDOM_BEACON)); 
        
               // This request is actually only invoked at the first epoch of the period. 
        
               randomBeacon.execRequestRandomSeedForNextPeriod(lastPeriod, newPeriod); 
        
               // Get all candidate ids 
        
               address[] memory allCids = _candidateIds; 
        
               _syncFastFinalityReward({ epoch: epoch, validatorIds: allCids }); 
        
               if (periodEnding) { 
        
                 ISlashIndicator slashIndicatorContract = ISlashIndicator(getContract(ContractType.SLASH_INDICATOR)); 
        
                 // Slash submit random beacon proof unavailability first, then update credit scores. 
        
                 randomBeacon.execRecordAndSlashUnavailability(lastPeriod, newPeriod, address(slashIndicatorContract), allCids); 
        
                 slashIndicatorContract.execUpdateCreditScores(allCids, lastPeriod); 
        
                 (uint256[] memory delegatorBlockMiningRewards, uint256[] memory delegatorFastFinalityRewards) = 
        
                   _distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward(lastPeriod, allCids); 
        
                 _settleAndTransferDelegatingRewards( 
        
                   lastPeriod, allCids, delegatorBlockMiningRewards, delegatorFastFinalityRewards 
        
                 ); 
        
                 _tryRecycleLockedFundsFromEmergencyExits(); 
        
                 _recycleDeprecatedRewards(); 
        
                 address[] memory revokedCandidateIds = _syncCandidateSet(newPeriod); 
        
                 if (revokedCandidateIds.length > 0) { 
        
                   // Re-update `allCids` after unsatisfied candidates get removed. 
        
                   allCids = _candidateIds; 
        
                   slashIndicatorContract.execResetCreditScores(revokedCandidateIds); 
        
                 } 
        
                 // Wrap up the beacon period includes (1) finalizing the beacon proof, and (2) determining the validator list for the next period by new proof. 
        
                 // Should wrap up the beacon after unsatisfied candidates get removed. 
        
                 randomBeacon.execFinalizeBeaconAndPendingCids(lastPeriod, newPeriod, allCids); 
        
                 _periodEndBlock[lastPeriod] = block.number; 
        
                 _currentPeriodStartAtBlock = block.number + 1; 
        
               } 
        
               // Clear the previous validator set and block producer set before sync the new set from beacon. 
        
               _clearPreviousValidatorSetAndBlockProducerSet(); 
        
               // Query the new validator set for upcoming epoch from the random beacon contract. 
        
               // Save new set into the contract storage. 
        
               address[] memory newValidatorIds = _syncValidatorSet(randomBeacon, newPeriod, nextEpoch); 
        
               // Activate applicable validators into the block producer set. 
        
               _updateApplicableValidatorToBlockProducerSet(newPeriod, nextEpoch, newValidatorIds); 
        
               emit WrappedUpEpoch(lastPeriod, epoch, periodEnding); 
        
               _periodOf[nextEpoch] = newPeriod; 
        
               _lastUpdatedPeriod = newPeriod; 
        
             } 
        
           }

ID-3
Reentrancy in CoinbaseExecution.wrapUpEpoch():
External calls:

dpos-contract/src/ronin/validator/CoinbaseExecution.sol

Lines 102 to 162 in 21d1a93

    
           function wrapUpEpoch() external payable virtual override onlyCoinbase whenEpochEnding oncePerEpoch { 
        
             unchecked { 
        
               uint256 newPeriod = _computePeriod(block.timestamp); 
        
               bool periodEnding = _isPeriodEnding(newPeriod); 
        
               uint256 lastPeriod = currentPeriod(); 
        
               uint256 epoch = epochOf(block.number); 
        
               uint256 nextEpoch = epoch + 1; 
        
               IRandomBeacon randomBeacon = IRandomBeacon(getContract(ContractType.RANDOM_BEACON)); 
        
               // This request is actually only invoked at the first epoch of the period. 
        
               randomBeacon.execRequestRandomSeedForNextPeriod(lastPeriod, newPeriod); 
        
               // Get all candidate ids 
        
               address[] memory allCids = _candidateIds; 
        
               _syncFastFinalityReward({ epoch: epoch, validatorIds: allCids }); 
        
               if (periodEnding) { 
        
                 ISlashIndicator slashIndicatorContract = ISlashIndicator(getContract(ContractType.SLASH_INDICATOR)); 
        
                 // Slash submit random beacon proof unavailability first, then update credit scores. 
        
                 randomBeacon.execRecordAndSlashUnavailability(lastPeriod, newPeriod, address(slashIndicatorContract), allCids); 
        
                 slashIndicatorContract.execUpdateCreditScores(allCids, lastPeriod); 
        
                 (uint256[] memory delegatorBlockMiningRewards, uint256[] memory delegatorFastFinalityRewards) = 
        
                   _distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward(lastPeriod, allCids); 
        
                 _settleAndTransferDelegatingRewards( 
        
                   lastPeriod, allCids, delegatorBlockMiningRewards, delegatorFastFinalityRewards 
        
                 ); 
        
                 _tryRecycleLockedFundsFromEmergencyExits(); 
        
                 _recycleDeprecatedRewards(); 
        
                 address[] memory revokedCandidateIds = _syncCandidateSet(newPeriod); 
        
                 if (revokedCandidateIds.length > 0) { 
        
                   // Re-update `allCids` after unsatisfied candidates get removed. 
        
                   allCids = _candidateIds; 
        
                   slashIndicatorContract.execResetCreditScores(revokedCandidateIds); 
        
                 } 
        
                 // Wrap up the beacon period includes (1) finalizing the beacon proof, and (2) determining the validator list for the next period by new proof. 
        
                 // Should wrap up the beacon after unsatisfied candidates get removed. 
        
                 randomBeacon.execFinalizeBeaconAndPendingCids(lastPeriod, newPeriod, allCids); 
        
                 _periodEndBlock[lastPeriod] = block.number; 
        
                 _currentPeriodStartAtBlock = block.number + 1; 
        
               } 
        
               // Clear the previous validator set and block producer set before sync the new set from beacon. 
        
               _clearPreviousValidatorSetAndBlockProducerSet(); 
        
               // Query the new validator set for upcoming epoch from the random beacon contract. 
        
               // Save new set into the contract storage. 
        
               address[] memory newValidatorIds = _syncValidatorSet(randomBeacon, newPeriod, nextEpoch); 
        
               // Activate applicable validators into the block producer set. 
        
               _updateApplicableValidatorToBlockProducerSet(newPeriod, nextEpoch, newValidatorIds); 
        
               emit WrappedUpEpoch(lastPeriod, epoch, periodEnding); 
        
               _periodOf[nextEpoch] = newPeriod; 
        
               _lastUpdatedPeriod = newPeriod; 
        
             } 
        
           }

ID-4
Reentrancy in CoinbaseExecution.wrapUpEpoch():
External calls:

dpos-contract/src/ronin/validator/CoinbaseExecution.sol

Lines 102 to 162 in 21d1a93

    
           function wrapUpEpoch() external payable virtual override onlyCoinbase whenEpochEnding oncePerEpoch { 
        
             unchecked { 
        
               uint256 newPeriod = _computePeriod(block.timestamp); 
        
               bool periodEnding = _isPeriodEnding(newPeriod); 
        
               uint256 lastPeriod = currentPeriod(); 
        
               uint256 epoch = epochOf(block.number); 
        
               uint256 nextEpoch = epoch + 1; 
        
               IRandomBeacon randomBeacon = IRandomBeacon(getContract(ContractType.RANDOM_BEACON)); 
        
               // This request is actually only invoked at the first epoch of the period. 
        
               randomBeacon.execRequestRandomSeedForNextPeriod(lastPeriod, newPeriod); 
        
               // Get all candidate ids 
        
               address[] memory allCids = _candidateIds; 
        
               _syncFastFinalityReward({ epoch: epoch, validatorIds: allCids }); 
        
               if (periodEnding) { 
        
                 ISlashIndicator slashIndicatorContract = ISlashIndicator(getContract(ContractType.SLASH_INDICATOR)); 
        
                 // Slash submit random beacon proof unavailability first, then update credit scores. 
        
                 randomBeacon.execRecordAndSlashUnavailability(lastPeriod, newPeriod, address(slashIndicatorContract), allCids); 
        
                 slashIndicatorContract.execUpdateCreditScores(allCids, lastPeriod); 
        
                 (uint256[] memory delegatorBlockMiningRewards, uint256[] memory delegatorFastFinalityRewards) = 
        
                   _distributeRewardToTreasuriesAndCalculateTotalDelegatorsReward(lastPeriod, allCids); 
        
                 _settleAndTransferDelegatingRewards( 
        
                   lastPeriod, allCids, delegatorBlockMiningRewards, delegatorFastFinalityRewards 
        
                 ); 
        
                 _tryRecycleLockedFundsFromEmergencyExits(); 
        
                 _recycleDeprecatedRewards(); 
        
                 address[] memory revokedCandidateIds = _syncCandidateSet(newPeriod); 
        
                 if (revokedCandidateIds.length > 0) { 
        
                   // Re-update `allCids` after unsatisfied candidates get removed. 
        
                   allCids = _candidateIds; 
        
                   slashIndicatorContract.execResetCreditScores(revokedCandidateIds); 
        
                 } 
        
                 // Wrap up the beacon period includes (1) finalizing the beacon proof, and (2) determining the validator list for the next period by new proof. 
        
                 // Should wrap up the beacon after unsatisfied candidates get removed. 
        
                 randomBeacon.execFinalizeBeaconAndPendingCids(lastPeriod, newPeriod, allCids); 
        
                 _periodEndBlock[lastPeriod] = block.number; 
        
                 _currentPeriodStartAtBlock = block.number + 1; 
        
               } 
        
               // Clear the previous validator set and block producer set before sync the new set from beacon. 
        
               _clearPreviousValidatorSetAndBlockProducerSet(); 
        
               // Query the new validator set for upcoming epoch from the random beacon contract. 
        
               // Save new set into the contract storage. 
        
               address[] memory newValidatorIds = _syncValidatorSet(randomBeacon, newPeriod, nextEpoch); 
        
               // Activate applicable validators into the block producer set. 
        
               _updateApplicableValidatorToBlockProducerSet(newPeriod, nextEpoch, newValidatorIds); 
        
               emit WrappedUpEpoch(lastPeriod, epoch, periodEnding); 
        
               _periodOf[nextEpoch] = newPeriod; 
        
               _lastUpdatedPeriod = newPeriod; 
        
             } 
        
           }

ID-5
Reentrancy in CandidateStaking.execDeprecatePools(address[],uint256):
External calls:
- ! _unsafeSendRONLimitGas(address(_pool.__shadowedPoolAdmin),deductingAmount,DEFAULT_ADDITION_GAS)
  - (success,None) = recipient.call{gas: gas,value: amount}()
- _unsafeSendRONLimitGas(address(_pool.__shadowedPoolAdmin),lastRewardAmount,DEFAULT_ADDITION_GAS)
  - (success,None) = recipient.call{gas: gas,value: amount}()
    State variables written after the call(s):
- delete _adminOfActivePoolMapping[_pool.__shadowedPoolAdmin]
  BaseStaking._adminOfActivePoolMapping can be used in cross function reentrancies:
- CandidateStaking.execDeprecatePools(address[],uint256)
- BaseStaking.getPoolAddressOf(address)
- BaseStaking.isAdminOfActivePool(address)
- lastRewardAmount = _claimReward(poolId,_pool.__shadowedPoolAdmin,newPeriod)
  - _reward.debited = 0
  - _reward.lastPeriod = lastPeriod
  - _reward.aRps = _stakingPool[poolId].aRps
    RewardCalculation._userReward can be used in cross function reentrancies:
- RewardCalculation._claimReward(address,address,uint256)
- RewardCalculation._getReward(address,address,uint256,uint256)
- RewardCalculation._syncUserReward(address,address,uint256)

dpos-contract/src/ronin/staking/CandidateStaking.sol

Lines 120 to 155 in 21d1a93

    
           function execDeprecatePools( 
        
             address[] calldata poolIds, 
        
             uint256 newPeriod 
        
           ) external override onlyContract(ContractType.VALIDATOR) { 
        
             if (poolIds.length == 0) { 
        
               return; 
        
             } 
        
             for (uint256 i = 0; i < poolIds.length;) { 
        
               address poolId = poolIds[i]; 
        
               PoolDetail storage _pool = _poolDetail[poolId]; 
        
               // Deactivate the pool admin in the active mapping. 
        
               delete _adminOfActivePoolMapping[_pool.__shadowedPoolAdmin]; 
        
               // Deduct and transfer the self staking amount to the pool admin. 
        
               uint256 deductingAmount = _pool.stakingAmount; 
        
               if (deductingAmount > 0) { 
        
                 _deductStakingAmount(_pool, deductingAmount); 
        
                 if (!_unsafeSendRONLimitGas(payable(_pool.__shadowedPoolAdmin), deductingAmount, DEFAULT_ADDITION_GAS)) { 
        
                   emit StakingAmountTransferFailed(_pool.pid, _pool.__shadowedPoolAdmin, deductingAmount, address(this).balance); 
        
                 } 
        
               } 
        
               // Settle the unclaimed reward and transfer to the pool admin. 
        
               uint256 lastRewardAmount = _claimReward(poolId, _pool.__shadowedPoolAdmin, newPeriod); 
        
               if (lastRewardAmount > 0) { 
        
                 _unsafeSendRONLimitGas(payable(_pool.__shadowedPoolAdmin), lastRewardAmount, DEFAULT_ADDITION_GAS); 
        
               } 
        
               unchecked { 
        
                 ++i; 
        
               } 
        
             } 
        
             emit PoolsDeprecated(poolIds); 
        
           }

shadowing-state

Impact: High
Confidence: High

ID-6
CandidateStaking.______gap shadows:
- BaseStaking.______gap
- RewardCalculation.______gap

dpos-contract/src/ronin/staking/CandidateStaking.sol

Line 27 in 21d1a93

uint256[48] ______gap;

ID-7
BaseStaking.______gap shadows:
- RewardCalculation.______gap

dpos-contract/src/ronin/staking/BaseStaking.sol

Line 40 in 21d1a93

uint256[49] private ______gap;

ID-8
CommonStorage.______gap shadows:

dpos-contract/src/ronin/validator/storage-fragments/CommonStorage.sol

Line 39 in 21d1a93

uint256[44] private ______gap;

ID-9
DelegatorStaking.______gap shadows:
- BaseStaking.______gap
- RewardCalculation.______gap

dpos-contract/src/ronin/staking/DelegatorStaking.sol

Line 13 in 21d1a93

uint256[50] private ______gap;

uninitialized-state

Impact: High
Confidence: High

ID-10
TimingStorage._firstTrackedPeriodEnd is never initialized. It is used in:
- TimingStorage.getPeriodEndBlock(uint256)

dpos-contract/src/ronin/validator/storage-fragments/TimingStorage.sol

Line 23 in 21d1a93

uint256 internal _firstTrackedPeriodEnd;

ID-11
TimingStorage._numberOfBlocksInEpoch is never initialized. It is used in:

dpos-contract/src/ronin/validator/storage-fragments/TimingStorage.sol

Line 10 in 21d1a93

uint256 internal _numberOfBlocksInEpoch;

ID-12
TimingStorage._periodOf is never initialized. It is used in:
- TimingStorage.tryGetPeriodOfEpoch(uint256)

dpos-contract/src/ronin/validator/storage-fragments/TimingStorage.sol

Line 19 in 21d1a93

mapping(uint256 epoch => uint256 period) internal _periodOf;

ID-13
Maintenance._schedule is never initialized. It is used in:

dpos-contract/src/ronin/Maintenance.sol

Line 21 in 21d1a93

mapping(address => Schedule) internal _schedule;

ID-14
JailingStorage._miningRewardDeprecatedAtPeriod is never initialized. It is used in:
- JailingStorage._miningRewardDeprecatedById(address,uint256)

dpos-contract/src/ronin/validator/storage-fragments/JailingStorage.sol

Line 9 in 21d1a93

    
           mapping(address => mapping(uint256 => bool)) internal _miningRewardDeprecatedAtPeriod;

ID-15
TimingStorage._lastUpdatedBlock is never initialized. It is used in:
- TimingStorage.getLastUpdatedBlock()

dpos-contract/src/ronin/validator/storage-fragments/TimingStorage.sol

Line 12 in 21d1a93

uint256 internal _lastUpdatedBlock;

ID-16
ValidatorInfoStorageV2._validatorCount is never initialized. It is used in:

dpos-contract/src/ronin/validator/storage-fragments/ValidatorInfoStorageV2.sol

Line 18 in 21d1a93

uint256 internal _validatorCount;

ID-17
TimingStorage._lastUpdatedPeriod is never initialized. It is used in:

dpos-contract/src/ronin/validator/storage-fragments/TimingStorage.sol

Line 14 in 21d1a93

uint256 internal _lastUpdatedPeriod;

ID-18
JailingStorage._blockProducerJailedBlock is never initialized. It is used in:
- JailingStorage._getJailedTimeLeftAtBlockById(address,uint256)
- JailingStorage._isJailedAtBlockById(address,uint256)

dpos-contract/src/ronin/validator/storage-fragments/JailingStorage.sol

Line 16 in 21d1a93

mapping(address => uint256) internal _blockProducerJailedBlock;

ID-19
ValidatorInfoStorageV2._validatorMap is never initialized. It is used in:
- ValidatorInfoStorageV2._isBlockProducerById(address)

dpos-contract/src/ronin/validator/storage-fragments/ValidatorInfoStorageV2.sol

Line 22 in 21d1a93

mapping(address cid => bool isBlockProducer) internal _validatorMap;

ID-20
TimingStorage._periodEndBlock is never initialized. It is used in:
- TimingStorage.getPeriodEndBlock(uint256)

dpos-contract/src/ronin/validator/storage-fragments/TimingStorage.sol

Line 21 in 21d1a93

mapping(uint256 period => uint256 endedAtBlock) internal _periodEndBlock;

ID-21
ValidatorInfoStorageV2._validatorIds is never initialized. It is used in:

dpos-contract/src/ronin/validator/storage-fragments/ValidatorInfoStorageV2.sol

Line 20 in 21d1a93

mapping(uint256 idx => address cid) internal _validatorIds;

ID-22
TimingStorage._currentPeriodStartAtBlock is never initialized. It is used in:
- TimingStorage.currentPeriodStartAtBlock()

dpos-contract/src/ronin/validator/storage-fragments/TimingStorage.sol

Line 16 in 21d1a93

uint256 internal _currentPeriodStartAtBlock;

github-actions · 2024-10-22T05:38:05Z

Storage Layout Change Report

Removed Components

…ework githook

huyhuynh3103

LGTM

* chore: rename src -> tools, contracts -> src * chore: update config and remove unused files, logs * test: restructure test * chore: apply new remapping config (#136) * chore: remove bridge related componets (#137) * chore: remove unused component * chore: remove unused artifact * chore: remove unused components * chore: remove unused testss * chore: move config -> script/config/vrf * script: fix script * chore: fix config * ci: update ci * chore: update post-commit * style(automated): post-commit forge fmt (*.sol) * chore(automated): post-commit update .git-blame-ignore-revs * ci: fix ci * ci: fix ci * test: skip fork test * ci: add ci for slither-analyze, storage-layout-check, unit-test and rework githook * chore: update .gitignore * chore: update post-commit * chore: add generate-artifact.sh * chore: update remappings.txt * ci: allow running check ci in implement-feature branch --------- Co-authored-by: tu-do.ron <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

TuDo1403 and others added 19 commits October 18, 2024 23:33

chore: rename src -> tools, contracts -> src

9aebbd5

Merge pull request #133 from ronin-chain/implement-feature/refactor/a…

d43d548

…pply-forge-structure feat(refactor): implement `apply-forge-structure`

chore: update config and remove unused files, logs

303cbb0

Merge pull request #134 from ronin-chain/implement-feature/refactor/u…

97affc2

…pdate-new-config feat(refactor): implement `update-new-config`

test: restructure test

c7b4912

Merge pull request #135 from ronin-chain/implement-feature/refactor/test

0d9e555

feat(refactor): implement `test`

chore: apply new remapping config (#136)

b34690d

Co-authored-by: TuDo1403 <[email protected]>

chore: remove bridge related componets (#137)

aab0368

Co-authored-by: TuDo1403 <[email protected]>

chore: remove unused component

02adf1f

chore: remove unused artifact

e48a702

chore: remove unused components

834c1ab

chore: remove unused testss

a7b0982

chore: move config -> script/config/vrf

c23cdeb

script: fix script

04bfcc9

chore: fix config

eb0ace8

ci: update ci

0852737

chore: update post-commit

566f558

style(automated): post-commit forge fmt (*.sol)

138b0b7

chore(automated): post-commit update .git-blame-ignore-revs

7d40e47

TuDo1403 changed the title ~~Feature/refactor~~ BREAKING_CHANGE: refactor repo Oct 21, 2024

ci: fix ci

3f5f8b1

TuDo1403 force-pushed the feature/refactor branch from 5e2a51c to 3f5f8b1 Compare October 21, 2024 06:36

TuDo1403 added 2 commits October 21, 2024 13:37

ci: fix ci

cf86a48

test: skip fork test

8589a5b

TuDo1403 force-pushed the feature/refactor branch 3 times, most recently from 6058231 to b2e7abf Compare October 22, 2024 04:55

TuDo1403 force-pushed the feature/refactor branch from ea5c6a6 to 520f147 Compare October 22, 2024 11:30

TuDo1403 force-pushed the feature/refactor branch 2 times, most recently from 454631d to fe14020 Compare October 22, 2024 11:40

ci: add ci for slither-analyze, storage-layout-check, unit-test and r…

3cfb932

…ework githook

TuDo1403 force-pushed the feature/refactor branch from 5bdbf37 to 3cfb932 Compare October 24, 2024 07:18

TuDo1403 added 4 commits October 25, 2024 14:24

chore: update .gitignore

081243c

chore: update post-commit

06ea9a3

chore: add generate-artifact.sh

31adc29

chore: update remappings.txt

5900eda

TuDo1403 force-pushed the feature/refactor branch from 40e1dd4 to 5900eda Compare October 25, 2024 07:25

ci: allow running check ci in implement-feature branch

4b47075

huyhuynh3103 approved these changes Oct 29, 2024

View reviewed changes

TuDo1403 merged commit d1d9de5 into release/v0.8.2 Dec 1, 2024
6 checks passed

TuDo1403 deleted the feature/refactor branch December 1, 2024 08:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BREAKING_CHANGE: refactor repo #138

BREAKING_CHANGE: refactor repo #138

TuDo1403 commented Oct 18, 2024 •

edited by tringuyenskymavis

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading

huyhuynh3103 left a comment

BREAKING_CHANGE: refactor repo #138

BREAKING_CHANGE: refactor repo #138

Conversation

TuDo1403 commented Oct 18, 2024 • edited by tringuyenskymavis Loading

Description

Contract changes

Checklist

github-actions bot commented Oct 22, 2024 • edited Loading

Slither report

reentrancy-eth

shadowing-state

uninitialized-state

github-actions bot commented Oct 22, 2024 • edited Loading

Storage Layout Change Report

Removed Components

huyhuynh3103 left a comment

Choose a reason for hiding this comment

TuDo1403 commented Oct 18, 2024 •

edited by tringuyenskymavis

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading