fix(RoninBaseTreasury): resolve comment

ronin-chain · Dec 1, 2024 · f0e83d2 · f0e83d2
1 parent 9edffd2
commit f0e83d2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/ronin/basefee-treasury/RoninBaseFeeTreasury.sol b/src/ronin/basefee-treasury/RoninBaseFeeTreasury.sol
@@ -487,7 +487,7 @@ contract RoninBaseFeeTreasury is EIP712, Initializable, HasContracts, GlobalConf
   function _calcMinVoteFor(
     uint256 totalVotePower
   ) internal view returns (uint96 minVoteFor) {
-    minVoteFor = ((totalVotePower * _threshold.num) / _threshold.denom).toUint96();
+    minVoteFor = (totalVotePower - _calcMinVoteAgainst(totalVotePower)).toUint96();
     require(minVoteFor != 0, ErrZeroMinVotePower());
   }
 
@@ -497,7 +497,7 @@ contract RoninBaseFeeTreasury is EIP712, Initializable, HasContracts, GlobalConf
   function _calcMinVoteAgainst(
     uint256 totalVotePower
   ) internal view returns (uint96 minVoteAgainst) {
-    minVoteAgainst = (totalVotePower - _calcMinVoteFor(totalVotePower)).toUint96();
+    minVoteAgainst = (totalVotePower * (_threshold.denom - _threshold.num) / _threshold.denom).toUint96();
     require(minVoteAgainst != 0, ErrZeroMinVotePower());
   }