Add SHORTENER_DICTIONARY setting #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
SHORTENER_DICTIONARYsetting to the app. This allows the user to have control over which characters will be used when a shortcode is created. If no dictionary is provided, the usual character set (lowercase letters, uppercase letters, digits, no confusing digits) will be used.Steps to test
Set the
SHORTENER_DICTIONARYsetting to"abcde"and run a few tests. Verify that the generated shortcodes are composed only by the "abcde" lettersRemove the
SHORTENER_DICTIONARYsetting and run a few more tests. Verify that the generated shortcodes follow the same usual pattern of django-link-shortener