Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify an opaque background for or FrostedContainer #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bill350
Copy link
Contributor

@bill350 bill350 commented Apr 10, 2015

We have a problem if we don't want the blur management.

I added a backgroundContainerColor property to set an UIColor to the FrostedContainer.
Typically, if we want liveBlur we have to specify it. The backgroundContainerColor takes the priority to the liveBlur if the color is different to nil

Moreover, if we don't want blur, it doesn't call re_applyBlurWithRadius function which costs a lot of CPU in... Main thread 👎 (before my request, the code test was if !liveBlur => call re_applyBlurWithRadius , it doesn't make sense ! Just let an opaque background.)

Open to discuss to improve my quick feature to be sure that it doesn't break other blur management.

So, the other issue which have to be fixed is to manage efficiently the GraphicBlur processing to a background queue or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant