-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spectroscopy module #212
spectroscopy module #212
Conversation
Hi @neilzim, the code here isn't in the model of step functions and data classes that we have for the rest of corgidrp. Is that something you have time to work on? If not, we need to find someone to make that interface before we can merge this code. We also should put the FITS files used in the tests in Git LFS, instead of being tracked via regular git. |
I will not have time to rework the functions + classes this fall. |
Let's not close this PR. I'm going to merge your changes into a |
@neilzim, before I merge, can you update add the FITS files in this PR into the |
If you give me write access to your fork of the repo, I can do it myself as well. |
added spectroscopy test input files
Sure, I've just modified the gitattributes to include all the test inputs. |
We need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for now, additional interface dev needed.
Describe your changes
Type of change
Reference any relevant issues (don't forget the #)
Checklist before requesting a review