Non linearity cleanup #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semaphoreP
reviewed
Sep 3, 2024
|
Ok, @semaphoreP, this is ready for re-review. |
semaphoreP
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
There were previously 3 different non_linearity examples that we were using to test things. This PR reduces it to 1 in order to reduce the number of files floating around.
A few of the tests had to be modified because they relied on a static fits file. This fits file is now generated dynamically when needed.
Type of change
Reference any relevant issues (don't forget the #)
This PR addresses ISsue #138
Checklist before requesting a review