feat(commonjs)!: revert #1909 and add requireNodeBuiltins option
#1937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sapphi-red <[email protected]>
Co-authored-by: sapphi-red <[email protected]>
Co-authored-by: sapphi-red <[email protected]>
Co-authored-by: sapphi-red <[email protected]>
shellscape
reviewed
Oct 29, 2025
|
@sapphi-red I'm going to mark this as a major just so it's clean. No worries about debates on whether it was breaking or not that way. |
shellscape
changed the title
requireNodeBuiltins optionrequireNodeBuiltins option
shellscape
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
Marked as Breaking by maintainers: This undoes a change and implements a new direction for a fix that was questionably breaking in a patch version. One of those "it's a bug but in certain situations it could be breaking" fixes. We'll make this a major to avoid any additional pain
List any relevant issue numbers:
resolves #1924
close #1931
Description
An alternative to #1931. Reverts #1909 and add
requireNodeBuiltinsoption that is specific for #1900 as requested.