Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace in build.gradle for RN 73 compatibility #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add namespace in build.gradle for RN 73 compatibility #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
apply plugin: 'com.android.library'

android {
def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
namespace "com.rollbar"
}

compileSdkVersion project.hasProperty('compileSdkVersion') ? project.compileSdkVersion : 27
buildToolsVersion project.hasProperty('buildToolsVersion') ? project.buildToolsVersion : "27.0.3"

Expand Down
6 changes: 1 addition & 5 deletions android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.rollbar">

</manifest>
<manifest package="com.rollbar" />