forked from yffaffy/rollbar
-
Notifications
You must be signed in to change notification settings - Fork 20
Fixed #138 Added PHP-Scoper to build to prevent dependency conflicts. #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielmorell
wants to merge
4
commits into
master
Choose a base branch
from
fixed/issue-136-composer-dependencies-conflict-with-other-plugins
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
11ff74c
Fixed #138 Added PHP-Scoper to build to prevent dependency conflicts.
danielmorell 8ed2bf6
Fixed PHP dependency versions not compatible with PHP 8.1
danielmorell 2718f83
Added unit tests to the result of the build script.
danielmorell fdafef0
Fixed space in release docs.
danielmorell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,3 +43,5 @@ intermediate | |
| cache | ||
| node_modules | ||
| vendor | ||
| dist | ||
| build | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| #! /bin/sh | ||
|
|
||
| set -e | ||
|
|
||
| echo "Building plugin ..." | ||
|
|
||
| ROOT_DIR=$(realpath "$(dirname "$(dirname "$0")")") | ||
|
|
||
| rm -rf "$ROOT_DIR/build" | ||
| mkdir -p "$ROOT_DIR/build" | ||
|
|
||
| echo " - Copying files to build/ ..." | ||
|
|
||
| cp -r "$ROOT_DIR/mu-plugin/" "$ROOT_DIR/build/mu-plugin/" | ||
| cp -r "$ROOT_DIR/public/" "$ROOT_DIR/build/public/" | ||
| cp -r "$ROOT_DIR/src/" "$ROOT_DIR/build/src/" | ||
| cp -r "$ROOT_DIR/templates/" "$ROOT_DIR/build/templates/" | ||
| cp "$ROOT_DIR/composer.json" "$ROOT_DIR/build/" | ||
| cp "$ROOT_DIR/composer.lock" "$ROOT_DIR/build/" | ||
| cp "$ROOT_DIR/LICENSE" "$ROOT_DIR/build/" | ||
| cp "$ROOT_DIR/README.md" "$ROOT_DIR/build/" | ||
| cp "$ROOT_DIR/readme.txt" "$ROOT_DIR/build/" | ||
| cp "$ROOT_DIR/rollbar.php" "$ROOT_DIR/build/" | ||
|
|
||
| echo " - Installing dependencies with Composer ..." | ||
|
|
||
| cd "$ROOT_DIR/build" | ||
|
|
||
| composer install --no-dev --optimize-autoloader | ||
|
|
||
| echo " - Namespace prefixing with PHP-Scoper ..." | ||
|
|
||
| cd "$ROOT_DIR" | ||
|
|
||
| rm -rf "$ROOT_DIR/dist" | ||
| vendor/bin/php-scoper add-prefix "$ROOT_DIR/build" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering about testing. Do we, or could we, have tests that ensure that the package as built by this script functions correctly? (For example, could we have the existing test suite test what's built by this script.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to think about this one for a while. We probably could add tests.
We would need to install the test dependencies in seperate vendor directory e.g.
vendor_testin thedistdirectory. From there we should be able to copy the files from the root of the repo needed to run tests:tests,.wp.env.json,package.json,package-lock.json,phpcs.xml, andphpunit.xml.I believe at that point the
distdirectory could run the test suite the same as the we do with the repo normally.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out as long as we run the
composer installfor our bundled dependencies during the build when we runcomposer installagain later to add our test dependencies the bundled dependencies won't be modified. Because of that we don't need avendor_distdirectory.