Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][SDK-348] Add uncaught exception to payload #319

Conversation

christianbuon
Copy link
Contributor

@christianbuon christianbuon commented Aug 19, 2024

Description of the change

  • Add is_uncaught field to the payload, so that the frontend differentiate between errors not caught by the user

New Payload example:

{
  "body": {
    "message": {
      "body": "An error caught by user"
    }
  },
  "is_uncaught": false,
  "uuid": "4f12a62118004563932257b40e9beed7",
  "language": "java",
  "level": "error",
  "timestamp": 1724033268,
  "environment": "production",
  "framework": "android",
  "client": {
    "name_version": "1.0",
    "timestamp": 1724033255,
    "code_version": 1,
    "version_code": 1,
    "user_ip": "123.456.789.123",
    "version_name": "1.0",
    "android": {
      "phone_model": "sdk_gphone64_arm64",
      "version_name": "1.0",
      "android_version": "14",
      "version_code": 1,
      "code_version": "1.0"
    }
  },
  "platform": "android",
  "notifier": {
    "version": "1.10.2-SNAPSHOT",
    "name": "rollbar-android"
  },
  "retentionDays": 180,
  "metadata": {
    "customer_timestamp": 1724033255.191
  }
}

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@christianbuon christianbuon self-assigned this Aug 19, 2024
@buongarzoni buongarzoni marked this pull request as ready for review September 1, 2024 00:55
@buongarzoni buongarzoni merged commit 6bfe332 into rollbar:master Oct 3, 2024
4 checks passed
@buongarzoni buongarzoni mentioned this pull request Oct 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants