Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][sdk-372] Fix CI - Old Android SDK removed from Ubuntu 20.04 image runner #314

Closed
wants to merge 40 commits into from
Closed

[fix][sdk-372] Fix CI - Old Android SDK removed from Ubuntu 20.04 image runner #314

Changes from 32 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
9765709
feat(ci): set up SDK manager path and install platform tools
christianbuon Jul 27, 2024
dc6389a
feat(ci): set up SDK manager older version for Java 8
christianbuon Jul 27, 2024
af8e058
feat(ci): add distribution
christianbuon Jul 27, 2024
3131f34
feat(ci): modify distribution
christianbuon Jul 27, 2024
bc5bfb7
feat(ci): just install old command line tool
christianbuon Jul 28, 2024
a7fbf94
feat(ci): install platform tools
christianbuon Jul 28, 2024
a301a77
feat(ci): use a newer version of skd tools
christianbuon Jul 28, 2024
581c58e
feat(ci): use a older version of skd tools
christianbuon Jul 28, 2024
b571567
feat(ci): use a older version of skd tools
christianbuon Jul 28, 2024
2a315af
feat(ci): use a older version of skd tools
christianbuon Jul 28, 2024
6dcece2
feat(ci): swap logs
christianbuon Jul 28, 2024
aa5d143
feat(ci): move log
christianbuon Jul 29, 2024
aac6078
feat(ci): install old platform tools
christianbuon Jul 29, 2024
d03cf43
feat(ci): add dash
christianbuon Jul 29, 2024
ed0bdf1
feat(ci): remove java 11
christianbuon Jul 30, 2024
da9843f
Revert "feat(ci): remove java 11"
christianbuon Jul 30, 2024
cb3581d
feat(ci): change command line tools version
christianbuon Aug 2, 2024
90e4b89
feat(ci): set old command line tools version
christianbuon Aug 2, 2024
3c2a3da
feat(ci): set old command line tools version
christianbuon Aug 2, 2024
c5e662b
feat(ci): change path
christianbuon Aug 2, 2024
fa149cb
feat(ci): try another version
christianbuon Aug 2, 2024
59eb57a
feat(ci): try another version
christianbuon Aug 2, 2024
ad80b7b
feat(ci): update sdkmanager
christianbuon Aug 3, 2024
3df0eeb
feat(ci): Setup Android SDK
christianbuon Aug 3, 2024
85d5b49
feat(ci): Setup Android SDK version 3.2.0
christianbuon Aug 3, 2024
995eec1
feat(ci): Setup Android SDK another version
christianbuon Aug 3, 2024
1807af4
feat(ci): Setup Android SDK another version
christianbuon Aug 3, 2024
98e11c4
feat(ci): Setup Android SDK version 10
christianbuon Aug 3, 2024
31a5d5e
feat(ci): Setup Android SDK version 9
christianbuon Aug 3, 2024
1bfd4a7
feat(ci): Setup Android SDK version 11
christianbuon Aug 3, 2024
4db881f
feat(ci): Setup Android SDK version 9 and add java 8 to sdk manager
christianbuon Aug 4, 2024
39daf35
feat(ci): fix variable
christianbuon Aug 4, 2024
cfe6388
feat(ci): remove third party action
christianbuon Aug 6, 2024
95fb718
build: make snapshot
christianbuon Aug 6, 2024
e95fda5
fix(ci): set command line tool older version
christianbuon Aug 6, 2024
f2db24b
fix(ci): set command line tool older version
christianbuon Aug 6, 2024
7f9f2f7
fix(ci): remove task
christianbuon Aug 6, 2024
c93d056
fix(ci): try to make snapshot with previous solution
christianbuon Aug 7, 2024
b56d80d
remove condition just for testing release
christianbuon Aug 7, 2024
b44e278
refactor: remove third party action
christianbuon Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ jobs:
- name: Fetch git tags
run: ./.github/fetch_to_tag.sh

- name: Setup Android SDK
uses: android-actions/setup-android@v3
with:
cmdline-tools-version: 9477386
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner image ships with this version. Do you think we can avoid adding a 3rd party tool for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but they upgraded the build tools and platform version from 27 to 31. Ok, I'm going to download it manually

Copy link
Contributor

@csaba-ilonka-rollbar csaba-ilonka-rollbar Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an example on how to install the old platform version with the existing SDK manager. You don't need to manually download it, or use 3rd party tools. If you don't install it, the Android Gradle Plugin figures out which version you need based on the project config and downloads it in the background.




# Our build uses JDK7's rt.jar to make sure the artifact is fully
# compatible with Java 7, so we let this action set Java 7 up for us
# and we store its JAVA_HOME
Expand All @@ -29,6 +36,16 @@ jobs:
- name: Capture JDK7_HOME
run: echo "export JDK7_HOME=\"$JAVA_HOME\"" > ~/.jdk7_home

- name: Set up Java 8
uses: actions/setup-java@v1
with:
java-version: 8

- name: Capture JDK8_HOME and set it to SDK manager
run: |
echo "export JDK8_HOME=\"$JAVA_HOME\"" > ~/.jdk8_home
sed -i "2i export JAVA_HOME=${JAVA_HOME}" ${ANDROID_SDK_ROOT}/tools/bin/sdkmanager

- name: Set up Java 17 (needed for Spring Boot 3)
uses: actions/setup-java@v1
with:
Expand All @@ -55,12 +72,12 @@ jobs:

- name: Environment info
run: |
java -version
javac -version
echo JAVA_HOME: ${JAVA_HOME}
./gradlew --version
echo ANDROID_SDK_ROOT: ${ANDROID_SDK_ROOT}
${ANDROID_SDK_ROOT}/tools/bin/sdkmanager --version
echo JAVA_HOME: ${JAVA_HOME}
java -version
javac -version

- name: Build
run: 'source ~/.jdk7_home && ./gradlew clean build'
Expand Down
Loading