Skip to content

feat(connect): print 'npx skills add' hint after successful wire#709

Merged
rohitg00 merged 1 commit into
mainfrom
feat/connect-skills-install-hint
May 28, 2026
Merged

feat(connect): print 'npx skills add' hint after successful wire#709
rohitg00 merged 1 commit into
mainfrom
feat/connect-skills-install-hint

Conversation

@rohitg00
Copy link
Copy Markdown
Owner

@rohitg00 rohitg00 commented May 28, 2026

Summary

Close the loop on the native-surface audit in #708. The skills CLI (vercel-labs) covers 4 of the 5 agents from #677 (warp, cline, continue, droid) plus 45+ others — wiring that path into the agentmemory UX saves ~600 LOC of would-be per-agent adapter code and tracks new agents automatically as the upstream keyword list grows.

Changes

  • src/cli/connect/index.tssummarize() prints a one-line npx skills add rohitg00/agentmemory -y next-step after any successful or already-wired adapter run. No subprocess spawn — keeps connect offline-capable and deterministic.
  • README.md — install snippet bumped from a one-line connect to the two-line flow. Adds "Native skills via npx skills add (50+ agents)" subsection under "Other agents" explaining the two-step pattern (connect writes MCP config, skills add installs native skills).

Tested

◇  Repository cloned
◇  Found 8 skills
◇  Available Skills
    commit-context, commit-history, ... (8 total)

npx skills add rohitg00/agentmemory --list against the public repo enumerates all 8 skills correctly.

Test plan

  • npm run build clean
  • npx vitest run test/cli-connect.test.ts — 22/22 pass
  • Manual: agentmemory connect codex --dry-run shows the new hint line after the existing "Restart any wired agent" outro.

Refs #708. Closes the documentation gap from the 5 agents in #677 (#703, #704, #705, #707 closed-as-redundant). #706 (Zed) stays open — not in the skills CLI keyword list yet.

Summary by CodeRabbit

  • Documentation

    • Enhanced quickstart instructions with native skills installation steps.
    • Added dedicated setup section for installing native skills via CLI with usage examples.
  • New Features

    • CLI now displays next-step guidance to install native skills after successful agent setup.

Review Change Stack

PR #677 shipped 5 MCP-only adapters (Warp, Cline, Continue, Zed, Droid)
but didn't ship native skill installs, which left ~600 LOC of
per-agent file-tree manipulation on the table. Turns out the
vercel-labs/skills CLI already covers 4 of the 5 (warp, cline,
continue, droid) plus 45+ other agents, reading SKILL.md files from
any git repo and installing to the calling agent's native directory.

This wires that path into the agentmemory UX without taking a new
runtime dep:

- `summarize()` in `src/cli/connect/index.ts` prints a one-line
  next-step pointing users at `npx skills add rohitg00/agentmemory -y`
  after any successful or already-wired adapter run. No subprocess
  spawn — keeps `connect` deterministic + offline-capable; the
  install is opt-in.
- README "Other agents" section gets a "Native skills via
  `npx skills add`" subsection explaining the two-step pattern
  (`connect` for MCP, `skills add` for skill autoload) and listing
  the 50+ supported agents.
- README install snippet bumps from one-line `connect` to the
  two-line flow so first-run users see both paths immediately.

Tracked via #708. Closes the audit angle for #703 / #704 / #705 /
#707 — see those issues' closing comments. #706 (Zed) remains open
since the skills CLI keyword list doesn't include Zed yet.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agentmemory Ready Ready Preview, Comment May 28, 2026 12:46pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d80ebc47-605a-4399-920c-bfccf8c5fccb

📥 Commits

Reviewing files that changed from the base of the PR and between d4c4061 and 2f963b6.

📒 Files selected for processing (2)
  • README.md
  • src/cli/connect/index.ts

📝 Walkthrough

Walkthrough

The PR enhances the user onboarding flow by adding native skills installation guidance. After successful agent wiring, the CLI now prompts users to install agentmemory's 8 native skills via the Vercel skills CLI. The README is updated to document this new feature with examples and explain how skills complement the MCP adapter connection.

Changes

Native Skills Installation Guidance

Layer / File(s) Summary
CLI summarize enhancement
src/cli/connect/index.ts
After successful agent wiring, the summarize() function now checks wiring results and outputs a "Next:" instruction directing users to install agentmemory skills using npx skills add rohitg00/agentmemory -y.
Installation documentation and examples
README.md
The Install quickstart adds the skills installation step, and a new "Native skills via npx skills add (50+ agents)" subsection documents the 8 shipped skills, auto-installation behavior across 50+ agents, usage examples for different install scopes, and clarification of how skills complement agentmemory connect.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Skills bloom in the garden so bright,
Eight talents installed in one CLI flight,
After wiring is done, users find the way,
To unlock agentmemory's powers today!
From README to prompt, the guidance shines clear. 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding a hint to print the 'npx skills add' command after a successful wire in the connect CLI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/connect-skills-install-hint

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@rohitg00 rohitg00 merged commit b8027c9 into main May 28, 2026
7 checks passed
@rohitg00 rohitg00 deleted the feat/connect-skills-install-hint branch May 28, 2026 12:55
rohitg00 added a commit that referenced this pull request May 28, 2026
rohitg00 added a commit that referenced this pull request May 28, 2026
* chore(release): v0.9.23

Bumps version across 9 files + adds CHANGELOG entry summarizing the
18 commits since v0.9.22.

Highlights:
- GitHub Copilot CLI first-class support (#534) — plugin + hooks +
  MCP with LSP-style Content-Length framing on the standalone stdio
  transport.
- Five new MCP adapters: Warp, Cline, Continue, Zed, Droid (#677);
  ADAPTERS count 11 → 17.
- Three silent DX bugs fixed: graph extraction never fired on
  session end (#666 / #698), status reported zero memories (#666),
  consolidation defaulted off even with an LLM provider configured
  (#612 / #696).
- Nine telemetry hooks switched to fire-and-forget so they don't
  block Claude Code's next-prompt boundary (#573 / #688).
- Hook project field now sends repo basename instead of full
  filesystem path so auto-injected context isn't silently filtered
  out (#474 / #687).
- Local-LLM docs: Ollama / LM Studio / vLLM section added (#671 /
  #697).

Version-bump files: package.json, plugin/.claude-plugin/plugin.json,
plugin/plugin.json, plugin/.codex-plugin/plugin.json,
packages/mcp/package.json, src/version.ts, src/types.ts,
src/functions/export-import.ts, test/export-import.test.ts.

* chore(release): add #701 + #709 to v0.9.23 CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant