Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE]: cleanup #378

Merged
merged 2 commits into from
May 1, 2023
Merged

[CHORE]: cleanup #378

merged 2 commits into from
May 1, 2023

Conversation

ashutosh887
Copy link
Contributor

Fixes Issue #270

Changes proposed

removed unwanted dependencies:

  • lottie-react
  • react-drag-drop-files
  • react-particles

@vercel
Copy link

vercel bot commented Apr 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
projectmate ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2023 4:29pm

@ashutosh887 ashutosh887 changed the title improve codebase: cleanup [chore]: cleanup Apr 29, 2023
@ashutosh887 ashutosh887 changed the title [chore]: cleanup [CHORE]: cleanup Apr 29, 2023
Copy link
Contributor

@Yazdun Yazdun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ashutosh! I'm not sure about removing the lottie-react since we may want to use it in the future, but I'm going to approve this for now. @rohitdasu what do you think about removing lotties?

@ashutosh887
Copy link
Contributor Author

@Yazdun as discussed in #270

These were the unwanted dependencies for now: here

@rohitdasu
Copy link
Owner

@Yazdun as discussed in #270

These were the unwanted dependencies for now: here

hi @ashutosh887 i agree with @Yazdun about the lottie package. we may need this package in future. could you make sure it stays. thanks

package.json Outdated
@@ -23,21 +23,18 @@
"flowbite": "^1.6.3",
"flowbite-react": "^0.3.8",
"framer-motion": "^9.1.7",
"lottie-react": "^2.4.0",
"moment": "^2.29.4",
"next": "^13.2.1",
"next-auth": "^4.19.2",
"next-themes": "^0.2.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next themes can be removed

package.json Outdated
"react-error-boundary": "^3.1.4",
"react-hook-form": "^7.43.9",
"react-hot-toast": "^2.4.0",
"react-icons": "^4.7.1",
"react-markdown": "^8.0.5",
"react-particles": "^2.8.0",
"react-quill": "^2.0.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-quill also not needed.

@ashutosh887
Copy link
Contributor Author

Great I'll remove them

@ashutosh887
Copy link
Contributor Author

@rohitdasu updated as per your call

Should I replace img tag here?

and use next/image

PS: where does this component get rendered?

@rohitdasu
Copy link
Owner

@rohitdasu updated as per your call

Should I replace img tag here?

and use next/image

PS: where does this component get rendered?

This is currently not in use. Can be kept as is. Later we will see where we can show this. Thanks

Copy link
Owner

@rohitdasu rohitdasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rohitdasu
Copy link
Owner

@ashutosh887 thanks for the contribution. If possible please post the achievement in your twitter account tagging us (https://twitter.com/projectmateHQ)

@rohitdasu rohitdasu merged commit 1c8b4a8 into rohitdasu:main May 1, 2023
@ashutosh887
Copy link
Contributor Author

Sure @rohitdasu

@ashutosh887 ashutosh887 deleted the cleanup branch May 1, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants