-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE]: cleanup #378
[CHORE]: cleanup #378
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ashutosh! I'm not sure about removing the lottie-react since we may want to use it in the future, but I'm going to approve this for now. @rohitdasu what do you think about removing lotties?
hi @ashutosh887 i agree with @Yazdun about the lottie package. we may need this package in future. could you make sure it stays. thanks |
package.json
Outdated
@@ -23,21 +23,18 @@ | |||
"flowbite": "^1.6.3", | |||
"flowbite-react": "^0.3.8", | |||
"framer-motion": "^9.1.7", | |||
"lottie-react": "^2.4.0", | |||
"moment": "^2.29.4", | |||
"next": "^13.2.1", | |||
"next-auth": "^4.19.2", | |||
"next-themes": "^0.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next themes can be removed
package.json
Outdated
"react-error-boundary": "^3.1.4", | ||
"react-hook-form": "^7.43.9", | ||
"react-hot-toast": "^2.4.0", | ||
"react-icons": "^4.7.1", | ||
"react-markdown": "^8.0.5", | ||
"react-particles": "^2.8.0", | ||
"react-quill": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-quill also not needed.
Great I'll remove them |
@rohitdasu updated as per your call Should I replace img tag here?
and use next/image PS: where does this component get rendered? |
This is currently not in use. Can be kept as is. Later we will see where we can show this. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@ashutosh887 thanks for the contribution. If possible please post the achievement in your twitter account tagging us (https://twitter.com/projectmateHQ) |
Sure @rohitdasu |
Fixes Issue #270
Changes proposed
removed unwanted dependencies: