Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] improve codebase #270

Open
rohitdasu opened this issue Nov 13, 2022 · 21 comments
Open

[CHORE] improve codebase #270

rohitdasu opened this issue Nov 13, 2022 · 21 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rohitdasu
Copy link
Owner

Description

requirement:
refactor code
implement best practices
enhance readability

@rohitdasu rohitdasu added enhancement New feature or request good first issue Good for newcomers labels Nov 13, 2022
@rohitdasu rohitdasu self-assigned this Dec 17, 2022
@rohitdasu rohitdasu linked a pull request Jan 20, 2023 that will close this issue
@rohitdasu rohitdasu removed a link to a pull request Jan 20, 2023
@rohitdasu rohitdasu removed their assignment Apr 5, 2023
@ashutosh887
Copy link
Contributor

@rohitdasu I would like to work on this

@rohitdasu
Copy link
Owner Author

Sure

@ashutosh887
Copy link
Contributor

ashutosh887 commented Apr 28, 2023

Please assign and let me know what revamps are needed @rohitdasu

@rohitdasu
Copy link
Owner Author

Sure, for now, could you remove unused packages and asset files(for example lottie animations).

Once you done with the task please create a PR 🙌🏻

@ashutosh887
Copy link
Contributor

Thanks a lot @rohitdasu
How're the contributors section managed? Should I enlist myself there or it gets done automatically (just asking)

@rohitdasu
Copy link
Owner Author

Thanks a lot @rohitdasu

How're the contributors section managed? Should I enlist myself there or it gets done automatically (just asking)

It's automatic, after merging your PR it will be added

@ashutosh887
Copy link
Contributor

ashutosh887 commented Apr 29, 2023

Removed lottie-react
Apart from this, we have the following dependencies that can be removed:

Unused dependencies

  • @hookform/resolvers
  • flowbite-react
  • next-themes
  • react-drag-drop-files
  • react-markdown
  • react-particles
  • react-quill
  • ts-node
  • tsparticles-preset-links
  • usehooks-ts
    Unused devDependencies
  • @types/node
  • @types/uuid
  • autoprefixer
  • lint-staged
  • postcss
  • prettier-plugin-tailwindcss

I believe some of them are getting used in config files or somewhere here & there. Could you please have a look @rohitdasu .

@rohitdasu
Copy link
Owner Author

Removed lottie-react

Apart from this, we have the following dependencies that can be removed:

Unused dependencies

  • @hookform/resolvers

  • flowbite-react

  • next-themes

  • react-drag-drop-files

  • react-markdown

  • react-particles

  • react-quill

  • ts-node

  • tsparticles-preset-links

  • usehooks-ts

Unused devDependencies

  • @types/node

  • @types/uuid

  • autoprefixer

  • lint-staged

  • postcss

  • prettier-plugin-tailwindcss

I believe some of them are getting used in config files or somewhere here & there. Could you please have a look @rohitdasu .

Hi, postcss, prettier tailwind plugin, lint staged,useHooksts are required ones. Please check each dependency and it's usage, ex: Postcss is needed for TailwindCSS configuration

@rohitdasu
Copy link
Owner Author

Please raise a PR so that we can have better picture on it

@ashutosh887
Copy link
Contributor

@rohitdasu
This can be closed now

@rohitdasu
Copy link
Owner Author

@rohitdasu

This can be closed now

Let's keep it as is so that we can have more PRs on this issue. I believe improving codebase is a never ending process 😅

@HKAgrwl
Copy link

HKAgrwl commented Jun 13, 2023

Hi, @rohitdasu can I work on this issue?

@ashutosh887
Copy link
Contributor

Sure go ahead @HKAgrwl

@HKAgrwl
Copy link

HKAgrwl commented Jun 13, 2023

Can you recommend me something I should get started with?

@rohitdasu
Copy link
Owner Author

Can you recommend me something I should get started with?

could you check the issues that are present in this repo? if no issue is suitable for u than you can create one issue and work upon it. before working on the issue let us know. thanks

@muhammadbasitobaid
Copy link

@rohitdasu I think this issue is going to be open for a long time (as refactoring doesn't stop), can I also work on this issue?

@rohitdasu
Copy link
Owner Author

@rohitdasu I think this issue is going to be open for a long time (as refactoring doesn't stop), can I also work on this issue?

Sure, you can try to improve any piece of code

@0xchikku
Copy link

I would like to join and contribute to improve the codebase, can I? @rohitdasu

@rohitdasu
Copy link
Owner Author

I would like to join and contribute to improve the codebase, can I? @rohitdasu

Sure

@AKSHUNNA-DHAKAD
Copy link

Can I work on this

@rohitdasu
Copy link
Owner Author

Can I work on this

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants