Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -r for printing method receivers #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

segevfiner
Copy link

@segevfiner segevfiner commented Dec 26, 2018

Please consider if the format I'm printing these is OK:

foo.go:

package main

type Foo struct{}

func (f *Foo) bar() {

}

Running godef:

$ godef -t -r -f foo.go -o 52
foo.go:5:15
bar (*Foo) func()

Fixes #93
See: microsoft/vscode-go#2107

@segevfiner
Copy link
Author

@ramya-rao-a I will also be glad to hear what you think as we will have to parse this in vscode-go.

@ramya-rao-a
Copy link

The output looks good to me.

cc @rogpeppe @ianthehat

segevfiner added a commit to segevfiner/vscode-go that referenced this pull request Dec 31, 2018
segevfiner added a commit to segevfiner/vscode-go that referenced this pull request Jan 8, 2019
segevfiner added a commit to segevfiner/vscode-go that referenced this pull request Jan 9, 2019
ramya-rao-a pushed a commit to microsoft/vscode-go that referenced this pull request Jan 9, 2019
…umentation (#2223)

* Use the newly added receiver output from godef to get the correct documentation

See rogpeppe/godef#105

Part of #2107

* Review fixes
@segevfiner
Copy link
Author

ping @rogpeppe @ianthehat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants