-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -r for printing method receivers #105
Open
segevfiner
wants to merge
1
commit into
rogpeppe:master
Choose a base branch
from
segevfiner:print-receivers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segevfiner
force-pushed
the
print-receivers
branch
from
December 26, 2018 08:35
f4d59f7
to
8ca9207
Compare
segevfiner
force-pushed
the
print-receivers
branch
from
December 26, 2018 11:02
8ca9207
to
d195e2d
Compare
@ramya-rao-a I will also be glad to hear what you think as we will have to parse this in vscode-go. |
The output looks good to me. |
segevfiner
added a commit
to segevfiner/vscode-go
that referenced
this pull request
Dec 31, 2018
segevfiner
added a commit
to segevfiner/vscode-go
that referenced
this pull request
Jan 8, 2019
segevfiner
added a commit
to segevfiner/vscode-go
that referenced
this pull request
Jan 9, 2019
ramya-rao-a
pushed a commit
to microsoft/vscode-go
that referenced
this pull request
Jan 9, 2019
…umentation (#2223) * Use the newly added receiver output from godef to get the correct documentation See rogpeppe/godef#105 Part of #2107 * Review fixes
ping @rogpeppe @ianthehat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider if the format I'm printing these is OK:
foo.go:
Running
godef
:Fixes #93
See: microsoft/vscode-go#2107