-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the pickle error when dumping an estimator #140
Conversation
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 25 25
Lines 1016 1016
=======================================
Hits 1000 1000
Misses 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hI @imxtx It looks good, the only change I'd request is to rename the function from getter_fittness_values to ind_fitness_values, just to a keep track of the names from the DEAP package
Thanks!
cool,I will update it later.
Tianxin Xie
***@***.***
…---- Replied Message ----FromRodrigo ***@***.***>Date09/20/2023 00:41 ***@***.***> CcT.X. ***@***.***>***@***.***>SubjectRe: [rodrigo-arenas/Sklearn-genetic-opt] Fix the pickle error when dumping an estimator (PR #140)
@rodrigo-arenas requested changes on this pull request.
hI @imxtx It looks good, the only change I'd request is to rename the function from getter_fittness_values to ind_fitness_values, just to a keep track of the names from the DEAP package
Thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#140 (review)",
"url": "#140 (review)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
Rename the function from getter_fittness_values to ind_fitness_values to a keep track of the names from the DEAP package
This fix #83. When saving an estimator, the dump method will report an error due to module class members and lambda functions.
Solved two issues:
creator
as a class member ofGASearchCV
andGAFeatureSelectionCV
.