Improve test config validation and adjust environment variables

The validation in the Helpers.cs file was modified to throw an exception not only when a configuration value is null, but also when it's empty. This is to further improve error reporting in test scenarios. Also, in publish_to_nuget.yml and dotnet.yml files, environment variables related to Azure OpenAI were adjusted from 'env' to 'vars' for better consistency and to fix possible naming issues when running in GitHub Actions.
rodion-m · Nov 17, 2023 · 63fde7b · 63fde7b
1 parent fdb60b9
commit 63fde7b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -29,6 +29,6 @@ jobs:
       env:
         OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
         AZURE_OPENAI_API_KEY: ${{ secrets.AZURE_OPENAI_API_KEY }}
-        AZURE_OPENAI_ENDPOINT_URL: ${{ env.AZURE_OPENAI_ENDPOINT_URL }}
-        AZURE_OPENAI_DEPLOYMENT_NAME: ${{ env.AZURE_OPENAI_DEPLOYMENT_NAME }}
+        AZURE_OPENAI_ENDPOINT_URL: ${{ vars.AZURE_OPENAI_ENDPOINT_URL }}
+        AZURE_OPENAI_DEPLOYMENT_NAME: ${{ vars.AZURE_OPENAI_DEPLOYMENT_NAME }}
       run: dotnet test --no-build --verbosity normal
diff --git a/.github/workflows/publish_to_nuget.yml b/.github/workflows/publish_to_nuget.yml
@@ -26,8 +26,8 @@ jobs:
       env:
         OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
         AZURE_OPENAI_API_KEY: ${{ secrets.AZURE_OPENAI_API_KEY }}
-        AZURE_OPENAI_ENDPOINT_URL: ${{ env.AZURE_OPENAI_ENDPOINT_URL }}
-        AZURE_OPENAI_DEPLOYMENT_NAME: ${{ env.AZURE_OPENAI_DEPLOYMENT_NAME }}
+        AZURE_OPENAI_ENDPOINT_URL: ${{ vars.AZURE_OPENAI_ENDPOINT_URL }}
+        AZURE_OPENAI_DEPLOYMENT_NAME: ${{ vars.AZURE_OPENAI_DEPLOYMENT_NAME }}
       run: dotnet test --no-build --verbosity normal
 
     - name: Find NuGet packages

diff --git a/tests/OpenAI.Tests.Shared/Helpers.cs b/tests/OpenAI.Tests.Shared/Helpers.cs
@@ -25,7 +25,7 @@ public static string GetValueFromConfiguration(string key)
         {
             ArgumentNullException.ThrowIfNull(key);
             var value = Configuration[key];
-            if (value is null)
+            if (value is null or { Length: 0 })
             {
                 throw new InvalidOperationException($"{key} is not set in configuration");
             }