Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially revert #18108: go back to canonical coq.inria.fr URLs. #18155

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Partially revert #18108: go back to canonical coq.inria.fr URLs. #18155

merged 1 commit into from
Oct 13, 2023

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Oct 12, 2023

Partially revert #18108: go back to canonical coq.inria.fr URLs.

Now that redirects work for them and old doc versions were uploaded to the doc repo.

Cf. rocq-prover/coq.github.io#233.

@Zimmi48
Partially revert rocq-prover#18108: go back to canonical coq.inria.fr…
4c7510d 
… URLs.

Now that redirects work for them and old doc versions were uploaded to the doc repo.
@Zimmi48 Zimmi48 added kind: documentation Additions or improvement to documentation. kind: infrastructure CI, build tools, development tools. labels Oct 12, 2023
@Zimmi48 Zimmi48 added this to the 8.19+rc1 milestone Oct 12, 2023
@Zimmi48 Zimmi48 requested a review from a team as a code owner October 12, 2023 19:44
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Oct 12, 2023
@jfehrle jfehrle assigned jfehrle and unassigned jfehrle Oct 12, 2023
jfehrle
jfehrle approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jfehrle jfehrle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK but mostly expecting that you've done the right thing

Perhaps Maxime would be the best assignee? Or I can do it.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Oct 13, 2023

Looks OK but mostly expecting that you've done the right thing

I've checked that all the links included are correct by opening them.

Perhaps Maxime would be the best assignee? Or I can do it.

Maxime has left all the maintainers teams (after he moved to a different position at Inria), so he cannot merge PRs on the Coq repository anymore.

@Zimmi48 Zimmi48 removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Oct 13, 2023
@jfehrle
Copy link
Member

jfehrle commented Oct 13, 2023

@coqbot merge now

@coqbot-app
Copy link
Contributor

coqbot-app bot commented Oct 13, 2023

@jfehrle: You cannot merge this PR because:

  • You are not among the assignees.

@jfehrle jfehrle self-assigned this Oct 13, 2023
@jfehrle
Copy link
Member

jfehrle commented Oct 13, 2023

@coqbot merge no

@jfehrle
Copy link
Member

jfehrle commented Oct 13, 2023

@coqbot merge now

@coqbot-app coqbot-app bot merged commit c4337d3 into rocq-prover:master Oct 13, 2023
@Zimmi48 Zimmi48 deleted the switch-urls-back-to-canonical-url branch January 22, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfehrle jfehrle jfehrle approved these changes

Assignees

@jfehrle jfehrle

Labels
kind: documentation Additions or improvement to documentation. kind: infrastructure CI, build tools, development tools.
Projects
None yet
Milestone
8.19+rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@Zimmi48 @jfehrle