Coroutines, Event Loops - Build Your Own in Scala #350
Conversation
* Prerequisite * Structure layout * Dependencies * Higher overview * Task and Coroutine
|
Hi @daniel-ciocirlan, I follow the CONTRIBUTING.md doc. But please let me know if anything that needs to be updated/ corrected at my side. Many thanks. |
daniel-ciocirlan
left a comment
daniel-ciocirlan
left a comment
There was a problem hiding this comment.
I think this is a valuable guide, with lots of lessons inside. I mostly commented on the flow of the article and some English nits.
The big thing that's missing in this article is (maybe surprisingly) "async", which we usually understand as the ability to run computations on callbacks later. The current code should allow this extension, and it would be valuable to add. If you don't want to add callbacks and just focus on coroutines and event loops, we can describe the article as such, and cut "async" out.
I'm very eager to read this article again after addressing the comments. Thank you for it.
chlin501
changed the title
|
Hi @daniel-ciocirlan, I updated the article and related code based on the comments. Please let me know if any issues. Many thanks. |
I may revisit this later - allowing to run computations on callbacks later. At the moment, I just cut out the async part. Thanks. Edit: |
daniel-ciocirlan
left a comment
daniel-ciocirlan
left a comment
There was a problem hiding this comment.
One last comment about the photo (up to you to decide), otherwise the article looks good.
Will merge after the Black Friday sale so that your article can have the visibility it deserves.
|
I am perfectly fine with my face shown up blurry on the blog. Thank you again for your advice. and efforts. I sincerely appreciate it!
|
2 participants
Update the author information to src/data/authors directory
Add the article build your own async to src/data/articles directory