Skip to content

Add generic callAPI - #1196

Merged
0xfornax merged 2 commits into
masterfrom
add-generic-call-api
Aug 27, 2026
Merged

Add generic callAPI #1196
0xfornax merged 2 commits into
masterfrom
add-generic-call-api

Conversation

@0xfornax

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

Coverage Report

@0xfornax
0xfornax force-pushed the add-generic-call-api branch from 5f89958 to 23f9412 Compare August 26, 2026 21:46
@github-actions

Copy link
Copy Markdown

Coverage Report

@0xfornax 0xfornax changed the title Add callAPI generic call Add generic callAPI Aug 26, 2026
@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool/api/service 0.30% (ø)
github.com/rocket-pool/smartnode/rocketpool/node 0.53% (+0.10%) 👍
github.com/rocket-pool/smartnode/shared/services/rocketpool 0.00% (ø)
github.com/rocket-pool/smartnode/shared/types/api 3.94% (-0.12%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool/api/service/gas.go 0.00% (ø) 231 0 231
github.com/rocket-pool/smartnode/rocketpool/node/auto-tx-gas.go 8.27% (+8.27%) 532 (+532) 44 (+44) 488 (+488) 👍
github.com/rocket-pool/smartnode/rocketpool/node/defend-challenge-exit.go 0.00% (ø) 3041 (-326) 0 3041 (-326)
github.com/rocket-pool/smartnode/rocketpool/node/defend-pdao-props.go 0.00% (ø) 3829 (-253) 0 3829 (-253)
github.com/rocket-pool/smartnode/rocketpool/node/distribute-minipools.go 0.00% (ø) 3005 (-275) 0 3005 (-275)
github.com/rocket-pool/smartnode/rocketpool/node/notify-final-balance.go 0.00% (ø) 3861 (-328) 0 3861 (-328)
github.com/rocket-pool/smartnode/rocketpool/node/notify-validator-exit.go 0.00% (ø) 3701 (-330) 0 3701 (-330)
github.com/rocket-pool/smartnode/rocketpool/node/prestake-megapool-validator.go 0.00% (ø) 2445 (-350) 0 2445 (-350)
github.com/rocket-pool/smartnode/rocketpool/node/provision-express-tickets.go 0.00% (ø) 1985 (-280) 0 1985 (-280)
github.com/rocket-pool/smartnode/rocketpool/node/set-latest-delegate.go 0.00% (ø) 2837 (-274) 0 2837 (-274)
github.com/rocket-pool/smartnode/rocketpool/node/stake-megapool-validator.go 0.00% (ø) 3439 (-331) 0 3439 (-331)
github.com/rocket-pool/smartnode/rocketpool/node/verify-pdao-props.go 2.70% (+0.10%) 6731 (-254) 182 6549 (-254) 👍
github.com/rocket-pool/smartnode/shared/services/rocketpool/api.go 0.00% (ø) 358 (+129) 0 358 (+129)
github.com/rocket-pool/smartnode/shared/services/rocketpool/auction.go 0.00% (ø) 1121 (-1916) 0 1121 (-1916)
github.com/rocket-pool/smartnode/shared/services/rocketpool/client.go 0.00% (ø) 19756 (-127) 0 19756 (-127)
github.com/rocket-pool/smartnode/shared/services/rocketpool/gas.go 0.00% (ø) 52 (-210) 0 52 (-210)
github.com/rocket-pool/smartnode/shared/services/rocketpool/megapool.go 0.00% (ø) 1068 (-7486) 0 1068 (-7486)
github.com/rocket-pool/smartnode/shared/services/rocketpool/minipool.go 0.00% (ø) 1251 (-4725) 0 1251 (-4725)
github.com/rocket-pool/smartnode/shared/services/rocketpool/network.go 0.00% (ø) 365 (-1772) 0 365 (-1772)
github.com/rocket-pool/smartnode/shared/services/rocketpool/node.go 0.00% (ø) 3229 (-16073) 0 3229 (-16073)
github.com/rocket-pool/smartnode/shared/services/rocketpool/odao.go 0.00% (ø) 1878 (-10264) 0 1878 (-10264)
github.com/rocket-pool/smartnode/shared/services/rocketpool/pdao.go 0.00% (ø) 1931 (-9807) 0 1931 (-9807)
github.com/rocket-pool/smartnode/shared/services/rocketpool/queue.go 0.00% (ø) 327 (-1167) 0 327 (-1167)
github.com/rocket-pool/smartnode/shared/services/rocketpool/security.go 0.00% (ø) 547 (-3728) 0 547 (-3728)
github.com/rocket-pool/smartnode/shared/services/rocketpool/service.go 0.00% (ø) 78 (-609) 0 78 (-609)
github.com/rocket-pool/smartnode/shared/services/rocketpool/upgrades.go 0.00% (ø) 78 (-609) 0 78 (-609)
github.com/rocket-pool/smartnode/shared/services/rocketpool/wallet.go 0.00% (ø) 813 (-2888) 0 813 (-2888)
github.com/rocket-pool/smartnode/shared/types/api/api.go 0.00% (ø) 26 (+26) 0 26 (+26)
github.com/rocket-pool/smartnode/shared/types/api/auction.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/debug.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/megapool.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/minipool.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/network.go 0.00% (ø) 179 0 179
github.com/rocket-pool/smartnode/shared/types/api/node.go 5.12% (ø) 683 35 648
github.com/rocket-pool/smartnode/shared/types/api/odao.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/pdao.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/queue.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/security.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/service.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/upgrades.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/wallet.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/rocket-pool/smartnode/rocketpool/node/auto-tx-gas_test.go

@0xfornax
0xfornax marked this pull request as ready for review August 26, 2026 22:42
@0xfornax
0xfornax merged commit 01e5b05 into master Aug 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant