Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Script Usage In Other Scripts #444

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

phalestrivir
Copy link
Contributor

This PR updates the --usage flag for script list and script describe commands to also find where scripts are being used in other scripts (i.e. where they are being used as library scripts).

@phalestrivir
Copy link
Contributor Author

I'm not sure why the tests are failing in action checks. I just ran the tests again on my local machine and they are all passing, so try re-running them to see if that fixes it.

@vscheuber vscheuber merged commit 31d0150 into rockcarver:main Sep 21, 2024
11 checks passed
@vscheuber
Copy link
Contributor

vscheuber commented Sep 21, 2024

@phalestrivir I think it is only the node18 tests that were failing and I have seen them fail frequently. I think it is typically due to timeouts. Node18 tests run 4-7 times slower than node20 and node22 tests...

I just re-ran the failed tests and they passed on 2nd attempt.

@phalestrivir phalestrivir deleted the feature/improve-script-usage branch November 12, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants