Skip to content

feature: light mode #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JulianKominovic
Copy link

Hi! I'm opening my first open source PR to enable light mode in the docs and home page 🤠.
The dark theme remains the same.
Let me know if you want to change something, I'm open to comments 👍

Changes log

  • Added some tailwind variables to the light theme.
  • Added the theme context
  • Theme switch button is located on the navbar
  • Some logos were SVGs and the fill colors were hardcoded. Now some of the SVG logos are components and inherits the color of the parent (I didn't convert all the icons to react component, just the conflicting ones)
  • The navbar was a bit messy (just the layout and positioning). In the current state I couldn't place the icon without visual bugs so I've done a mini refactor there deleting all the positions hacks of the search bar and the logo.

Evidence

Group 1

Copy link

vercel bot commented May 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zero-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 1:20am

@aboodman
Copy link
Contributor

I have traditionally been against this, but I think I'm ready to try it.

@alexhking I think maybe the logo should be a step or two lighter? Something about the name "zero" in this bright context says '75% grey' to me, not black.

@JulianKominovic I don't think the toggle should be top-right, but down here:

CleanShot 2025-05-09 at 16 08 01@2x

I realize this will make it harder to find but I still think we should try it.

I think we should set it as defaulted to sync to theme.

@alexhking this highlight color doesn't feel right to me:

CleanShot 2025-05-09 at 16 10 36@2x

The logo has shifted up about 5px in the new layout and is no longer aligned w/ the buttons:

CleanShot 2025-05-09 at 16 11 57@2x copy

And probably various other things as you think appropriate @alexhking

@JulianKominovic - feel free to do any of these or not. If not, we will take over np. Thank you very much for the contribution.

@alexhking
Copy link
Contributor

@JulianKominovic Thanks so much for the contribution. Have been reviewing this and I'd like to make a few adjustments to the overall style and positioning of things. Will update this branch and then we can merge.

@JulianKominovic
Copy link
Author

Hi @alexhking @aboodman! Sorry for the late reply, it's been a very long week. Sure, go ahead. Let me know if you need anything 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants