Skip to content

docs: fix various typos and code errors #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

charpeni
Copy link
Contributor

@charpeni charpeni commented Apr 29, 2025

Found some typos as well as broken code examples when reading through.

Copy link

vercel bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zero-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 2:46pm

Copy link
Contributor

@aboodman aboodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these great fixes!

@aboodman aboodman merged commit 2f79ca6 into rocicorp:main Apr 30, 2025
2 checks passed
@charpeni charpeni deleted the various-typos branch May 1, 2025 00:32
Comment on lines +271 to 274
const { server } = await zero.mutate.issue.update({
id: 'issue-123',
title: 'New title',
}).server;
Copy link
Contributor

@tantaman tantaman May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither the old documentation nor the new documentation is correct.

const {server} = zero.mutate.issue.update({
  id: 'issue-123',
  title: 'New title',
})

would be correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to delete it when restructuring.

Here's a pull request: #119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants