[zig] Parser: Add support for basic import exposes #7673
+78
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smores56
reviewed
Mar 7, 2025
| } | ||
| n += 1; | ||
| } | ||
| fmt.push(']'); |
There was a problem hiding this comment.
Will there be a coherent effort at some point to handle optional multiline formatting (either based on trailing commas or newlines)? I presume so, which is why I haven't been commenting about it.
There was a problem hiding this comment.
We also need to support moving comments over, and my thinking is to handle those both in the same way. (altho I do like the trailing comment behavior!)
| const scratch_top = self.store.scratchTokenTop(); | ||
| while (self.peek() != .CloseSquare) { | ||
| if (self.parseIdent()) |ident| { | ||
| self.store.addScratchToken(ident); |
There was a problem hiding this comment.
It would be nice if the exposes field would hold an enum along the lines of
const ExposedItem = union(enum) {
value: Ident.Idx,
@"type": Ident.Idx,
custom_union: struct {
name: Ident.Idx,
tags: []Ident.Idx,
},
};The main benefit of value being distinct from @"type" is that we don't have to look at the first letter of the text to check if it's uppercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE! Working on supporting all exposes syntax.