DO NOT MERGE Upgrade examples to Purity Inference #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-4
changed the title
|
fyi I added "DO NOT MERGE" so this is held until the basic-cli pre-release becomes a full release |
Anton-4
requested changes
Dec 28, 2024
| main = | ||
| Stdout.line! (Inspect.toStr (parseNameAndYear "Alice was born in 1990")) | ||
| Stdout.line! (Inspect.toStr (parseNameAndYearTry "Alice was born in 1990")) | ||
| main! = \_ -> |
There was a problem hiding this comment.
In the basic-cli examples we've been using main! = \_args -> everywhere, I prefer it like that, it's more transparent. What do you think?
There was a problem hiding this comment.
Agree... I just never came back to these and made the changes here yet.
|
|
||
| # Generate a list of numbers using the seed and generator provided | ||
| # This is NOT cryptograhpically secure! |
There was a problem hiding this comment.
Seems like we should keep this 😄
|
|
||
| sum = Task.loop! 0 addNumberFromStdin |
There was a problem hiding this comment.
We should rename this example 😄
examples/Tasks/main.roc
Outdated
There was a problem hiding this comment.
Need to rename this one as well. The README for this example also needs to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.