template draft #47
Merged
template draft #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great to me - I'm assuming that every project is going to need to add a few things of its own to its own |
|
@gvwilson Great! We could move the gitignore to the top level; it doesn't matter to me. I will send a message in Zulip about feedback and if there is none by tomorrow you can merge it then. We can always have more feedback down the line also. |
|
Related to #5 |
|
Looks nice and clean :) |
|
@gvwilson This is ready to merge when you get a chance. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my first draft of the HTML template engine. It is already quite nice to use which I am very happy about. I will start a related topic on Zulip about how we should do parsing in the book. Cheers! @gvwilson