Graphic.js: darker green for qsubcolor1 #280
Conversation
This makes the green color used for qsubcolor1 (eg, for slither) darker and thus more distinguishable from the yellow used for qsubcolor2 by people with some forms of colorblindness. The particular color chosen is inspired by https://sashamaps.net/docs/resources/20-colors/ though I am not tweaking the other colors to come from here. Fixes robx#255.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hmm, this is probably too close to the default (not "color each line") line color:
|
Codecov ReportBase: 88.58% // Head: 88.58% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 88.58% 88.58%
=======================================
Files 164 164
Lines 17927 17927
=======================================
Hits 15880 15880
Misses 2047 2047
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Yeah I don't think we should go for darker shading. I was hoping (one of) the shades could be tweaked to something that's more apparently different from the other, without increasing the "contrast" in terms of darkness. |
|
Well, the contrast in terms of darkness is admittedly what many colorblind folks can see — but if you're comfortable just completely changing a color then that works too. I use pink as my secondary color in penpa fwiw. |
|
So what would be ideal is to have a change that keeps looking "nice" for everyone but is better in terms of accessibility, and particularly good enough for you. I'm not opposed to switching out the colors within those parameters. I don't know enough about the various forms of color blindness to be able to tell whether it's realistic to find a single color scheme that works, there. If that doesn't work, I think the best alternative would be to add some kind of accessibility toggle (whether that be via stylesheet or a menu option) which would switch out the color scheme, and then you can go wild with how you'd like puzzles to look in "accessible mode". (Needn't be a single option if that's not selective enough, but it would be a good start.) That needn't be limited to changing the colors, e.g. it would be possible to draw thin XOs for the two shadings. |
This makes the green color used for qsubcolor1 (eg, for slither) darker and thus more distinguishable from the yellow used for qsubcolor2 by people with some forms of colorblindness.
The particular color chosen is inspired by https://sashamaps.net/docs/resources/20-colors/ though I am not tweaking the other colors to come from here.
Fixes #255.