Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for epd7in3e #102

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add support for epd7in3e #102

merged 2 commits into from
Oct 30, 2024

Conversation

antoinecellerier
Copy link
Contributor

@antoinecellerier antoinecellerier commented Oct 18, 2024

@robweber
Copy link
Owner

Thanks for contributing. Couple of questions:

  1. Have you tried the upstream waveshare repo in any long term capacity? Been a while since I've tried but there was a pretty critical error for most b/w EPDs where it would error out when trying to wake from sleep. I'll pull this and test on my own but just curious.
  2. Is your 7in3e implementation dependent on the upstream merge? At first glance I'm thinking no since the method calls are the same but unsure how the changed code affects actual use.

@antoinecellerier
Copy link
Contributor Author

I've not had the opportunity to test the upstream repo with other EPDs recently no. I only have the 7in5b and 7in3e displays so no opportunity to really test black and white :-/
The upstream merge isn't technically required for things to work, it just fixes the colors being all shuffled. e.g. blue shows up as red without the fix.

@robweber
Copy link
Owner

Currently running this with SlowMovie to ensure the previous Waveshare repo error is ironed out. So far so good. I'll let it run through the weekend. Usually I can run for months without issues, most of a week should be a good test. Otherwise it all looks good.

@antoinecellerier
Copy link
Contributor Author

thanks

@antoinecellerier
Copy link
Contributor Author

Looks like the color issue I had referenced on the waveshare repo got fixed 5 days ago without needing to merge the PR I'd shared. I've not verified it works yet but likely good news.

@robweber
Copy link
Owner

Been running this for a while without any major issues. Had one lock-up but I think that may have been related to the video file. In the past (when the bug was present) things failed within the first 30-60 minutes.

@robweber robweber merged commit 218ab3b into robweber:main Oct 30, 2024
@antoinecellerier antoinecellerier deleted the epd7in3e branch November 22, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants