Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes minor issue with generated templates having double document separator #1553

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

RoryDoherty
Copy link
Contributor

Moves the document separator into the if condition to avoid scenarios with multiple document separators with nothing in between. Some yaml tools cannot handle an empty doc e.g. checkov

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!
Thanks for fixing it @RoryDoherty

@arikalon1 arikalon1 merged commit 291fb62 into robusta-dev:master Sep 13, 2024
4 checks passed
@RoryDoherty RoryDoherty deleted the minor-template-fixes branch September 13, 2024 12:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants